Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Move S3, SQS, SNS and lambda lightweight module config into integration #3838

Merged
merged 7 commits into from
Jul 27, 2022
Merged

[AWS] Move S3, SQS, SNS and lambda lightweight module config into integration #3838

merged 7 commits into from
Jul 27, 2022

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jul 26, 2022

What does this PR do?

This PR is to move lightweight module configuration from metricbeat into integrations for s3_daily_storage, s3_request, SQS, SNS, lambda.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@kaiyan-sheng kaiyan-sheng marked this pull request as ready for review July 26, 2022 20:40
@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner July 26, 2022 20:40
@elasticmachine
Copy link

elasticmachine commented Jul 26, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-27T16:13:54.379+0000

  • Duration: 36 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 334
Skipped 0
Total 334

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kaiyan-sheng kaiyan-sheng self-assigned this Jul 26, 2022
@kaiyan-sheng kaiyan-sheng added Integration:aws AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Jul 26, 2022
@elasticmachine
Copy link

elasticmachine commented Jul 26, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (11/11) 💚
Files 91.667% (11/12) 👎 -5.454
Classes 91.667% (11/12) 👎 -5.454
Methods 82.464% (174/211) 👎 -6.768
Lines 92.894% (2157/2322) 👍 2.302
Conditionals 100.0% (0/0) 💚

@kaiyan-sheng kaiyan-sheng changed the title [AWS] Move S3 lightweight module config into integration [AWS] Move S3, SQS, SNS and lambda lightweight module config into integration Jul 26, 2022
@@ -13,7 +13,3 @@
type: object
description: |
Metric dimensions.
- name: '*.metrics.*.*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a change I do not understand! From what I understand this means that the events from this package do not contain this data structure anymore. But is this expected? I still see lambda.metrics.<fields> (es https://github.com/elastic/integrations/pull/3838/files#diff-ab8d12efcf395a213dbef900621dfe0f32e523b7f5a9692896869971264a1a4eR40) in the events so I'm not sure I'm looking in the right place.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is because there is the renaming in the ingest pipeline, so in the end these fields will not in the stored event?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha we are removing this field (tech debt, not related to lightweight module config) because the metrics we are collecting for lambda are already all listed and documented in fields.yml: https://github.com/elastic/integrations/blob/main/packages/aws/data_stream/lambda/fields/fields.yml#L16

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! So is this expected to be removed everywhere? Just to check for it in other integrations too ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah at least in aws package we added all the field names individually into fields.yml so we should remove this '*.metrics.*.*' from all data streams under aws.

Copy link
Member

@endorama endorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just a nitpick, I would bump the minor and not the patch version.

@kaiyan-sheng
Copy link
Contributor Author

Looks good to me! Just a nitpick, I would bump the minor and not the patch version.

😂 Too late haha I think all the PRs that moves lightweight module all only bumped the patch version 😂 Well...... I'm trying to be consistent haha

@kaiyan-sheng kaiyan-sheng merged commit 5222ef6 into elastic:main Jul 27, 2022
@kaiyan-sheng kaiyan-sheng deleted the s3_datastream branch July 27, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment