Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update instructions for synthetic source #3823

Merged
merged 1 commit into from
Jul 26, 2022
Merged

docs: update instructions for synthetic source #3823

merged 1 commit into from
Jul 26, 2022

Conversation

axw
Copy link
Member

@axw axw commented Jul 25, 2022

What does this PR do?

Update the docs about enabling synthetic source due to a recent change in Elasticsearch.
See elastic/elasticsearch#88211

@axw axw requested a review from joshdover July 25, 2022 10:19
@axw axw requested a review from a team as a code owner July 25, 2022 10:19
joshdover
joshdover approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elasticmachine
Copy link

elasticmachine commented Jul 25, 2022 •
edited
Loading

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-26T00:37:45.678+0000

  • Duration: 112 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 5317
Skipped 7
Total 5324

Steps errors 1

Expand to view the steps failures

Boot up the Elastic stack
  • Took 2 min 58 sec . View more details here
  • Description: ../../build/elastic-package stack up -d -v --version 7.15.0

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@axw
Copy link
Member Author

axw commented Jul 26, 2022

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (277/277) 💚
Files 97.099% (502/517) 👍 0.051
Classes 97.099% (502/517) 👍 0.051
Methods 89.344% (4863/5443) 👍 0.105
Lines 90.577% (88950/98204) 👍 0.054
Conditionals 100.0% (0/0) 💚

@axw
Copy link
Member Author

axw commented Jul 26, 2022

😩 CI is failing. Can someone please force-merge this?

@mtojek mtojek merged commit 362e78e into elastic:main Jul 26, 2022
@axw axw deleted the synthetic-source-howto branch July 26, 2022 06:42
@andresrc andresrc mentioned this pull request Jul 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

@joshdover joshdover joshdover approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@axw @elasticmachine @jsoriano @joshdover @mtojek