Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP] Convert GCP GKE metricset from lightweight #3793

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Jul 21, 2022

What does this PR do?

Convert GCP GKE metricset from lightweight

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 requested review from a team as code owners July 21, 2022 15:12
@elasticmachine
Copy link

elasticmachine commented Jul 21, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-19T19:53:01.956+0000

  • Duration: 19 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 82
Skipped 0
Total 82

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Jul 22, 2022

/test

@endorama endorama added Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Aug 1, 2022
@legoguy1000 legoguy1000 changed the title [GCP] Add GCP GKE Metricset [GCP] Convert GCP GKE metricset from lightweight Sep 19, 2022
@legoguy1000
Copy link
Contributor Author

@kaiyan-sheng ready to merge this once #3798 is merged.

@legoguy1000
Copy link
Contributor Author

@kaiyan-sheng ready for test.

@kaiyan-sheng
Copy link
Contributor

/test

@elasticmachine
Copy link

🚀 Benchmarks report

Package gcp 👍(5) 💚(0) 💔(0)

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚 2.516
Classes 100.0% (5/5) 💚 2.516
Methods 90.816% (89/98) 👍 0.574
Lines 95.752% (1375/1436) 👍 4.439
Conditionals 100.0% (0/0) 💚

@kaiyan-sheng kaiyan-sheng merged commit 4ddf3b2 into elastic:main Sep 19, 2022
@legoguy1000 legoguy1000 deleted the 490-gcp-gke branch September 19, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants