windows: enrich user details from MemberSid where possible #3707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
enhancement
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
andrewkroh
reviewed
Jul 14, 2022
efd6
commented
Jul 14, 2022
Comment on lines
34
to
39
| if: ctx.winlog?.event_data?._MemberAccountType != null | ||
| - remove: | ||
| field: _user | ||
| field: winlog.event_data._MemberAccountType | ||
| ignore_missing: true | ||
| ignore_failure: true | ||
| if: ctx.user?.roles != null && ctx.winlog?.event_data?._MemberAccountType != null && ctx.user.roles.contains(ctx.winlog.event_data._MemberAccountType) |
There was a problem hiding this comment.
Ideally I'd use an on_success attribute for this, but I don't think that exists.
andrewkroh
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This attempt to enrich user details from the event_data.MemberSid field if possible and the information is not othewise available.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots