-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gaps in the Prometheus integration (technical preview) #3662
Merged
tetianakravchenko
merged 2 commits into
elastic:main
from
tetianakravchenko:prometheus-integration
Jul 8, 2022
Merged
Fix gaps in the Prometheus integration (technical preview) #3662
tetianakravchenko
merged 2 commits into
elastic:main
from
tetianakravchenko:prometheus-integration
Jul 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s; collector: add leader election, remove default value for ssl; query: add leader election Signed-off-by: Tetiana Kravchenko <[email protected]>
Signed-off-by: Tetiana Kravchenko <[email protected]>
This was referenced Jul 7, 2022
🌐 Coverage report
|
gizas
reviewed
Jul 7, 2022
@@ -15,13 +15,18 @@ metrics_filters.include: | |||
metrics_path: {{metrics_path}} | |||
period: {{period}} | |||
rate_counters: {{rate_counters}} | |||
{{#if ssl.certificate_authorities}} | |||
ssl.certificate_authorities: | |||
{{#each ssl.certificate_authorities}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have many cert_authorities? Just wondering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
it defined by multi: true
setting in manifest
gizas
approved these changes
Jul 7, 2022
mlunadia
changed the title
Prometheus integration: minor enhancements as an outcome of evaluation issues
Prometheus integration: User experience enhancements
Jul 8, 2022
mlunadia
changed the title
Prometheus integration: User experience enhancements
Fix gaps in the Prometheus integration
Jul 18, 2022
mlunadia
changed the title
Fix gaps in the Prometheus integration
Fix gaps in the Prometheus integration (technical preview)
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s; collector: add leader election, remove default value for ssl; query: add leader election
Signed-off-by: Tetiana Kravchenko [email protected]
What does this PR do?
Those changes are the result of evaluation issue, for more details: #3489, #3487, #3488
remote_write datastream:
collectordatastream:
query datastream:
Checklist
changelog.yml
file.How to test this PR locally
Related issues
Screenshots
Collector:
Query:
remote_write:
with advanced options: