Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import-beats: prepend module names to Kibana dashboards #322

Merged
merged 4 commits into from
Oct 20, 2020
Merged

Fix import-beats: prepend module names to Kibana dashboards #322

merged 4 commits into from
Oct 20, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Oct 20, 2020

What does this PR do?

This PR fixes the migration script is to prepend modules names to Kibana dashboards.

Additionally:

  • I fixed issue with undefined event function in templates (not used in initial migration).

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@mtojek mtojek added the bug Something isn't working, use only for issues label Oct 20, 2020
@mtojek mtojek requested a review from ycombinator October 20, 2020 15:43
@mtojek mtojek self-assigned this Oct 20, 2020
@mtojek mtojek mentioned this pull request Oct 20, 2020
Closed
4 tasks
@elasticmachine
Copy link

elasticmachine commented Oct 20, 2020 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #322 updated]

  • Start Time: 2020-10-20T16:00:41.508+0000

  • Duration: 12 min 42 sec

ycombinator
ycombinator reviewed Oct 20, 2020
View reviewed changes
dev/import-beats/kibana.go Outdated
data = replaceBlacklistedWords(
replaceFieldEventDataStreamWithStreamDataStream(
data))
data = prependModuleNameToDashboard(replaceBlacklistedWords(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prependModuleNameToDashboard function name confused me for a bit since we had already done that in the new code above. I had to read the function body to realize it was about updating the dashboard links. Consider renaming the function to be more explicit about what it does?

Suggested change
data = prependModuleNameToDashboard(replaceBlacklistedWords(
data = prependModuleNameToDashboardLinks(replaceBlacklistedWords(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right here. Rephrased.

ycombinator
ycombinator approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mtojek mtojek merged commit 13c8890 into elastic:master Oct 20, 2020
@ycombinator ycombinator mentioned this pull request Oct 27, 2020
Closed
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@mtojek
Fix import-beats: prepend module names to Kibana dashboards (elastic#322
fc2a350 
)

* Prepend module names to imported Kibana dashboards

* Fix: bug, sample event may not be defined

* Fix: mage format

* Address PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

Assignees

@mtojek mtojek

Labels
bug Something isn't working, use only for issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtojek @elasticmachine @ycombinator