Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latency config into aws metrics data stream #308

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Add latency config into aws metrics data stream #308

merged 2 commits into from
Oct 15, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Oct 13, 2020

What does this PR do?

This PR is to add latency config into aws metrics data stream after merging elastic/beats#20875.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Screenshots

Screen Shot 2020-10-13 at 10 42 56 AM

@kaiyan-sheng kaiyan-sheng self-assigned this Oct 13, 2020
@elasticmachine
Copy link

elasticmachine commented Oct 13, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-10-15T01:45:47.124+0000

  • Duration: 9 min 39 sec

@@ -10,12 +10,18 @@ streams:
multi: false
required: true
show_user: true
default: 24h
default: 1m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the 1m period too often? Just wondering :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha s3 request metrics are 1m frequency on AWS side.

@kaiyan-sheng kaiyan-sheng merged commit cfda775 into elastic:master Oct 15, 2020
@kaiyan-sheng kaiyan-sheng deleted the latency_config branch October 15, 2020 13:10
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
* Add latency config into aws metrics data stream

* update version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants