Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hashicorp_vault] Clarify dynamic mapping for hashicorp_vault.metrics #2994

Merged
merged 1 commit into from
Apr 4, 2022
Merged

[hashicorp_vault] Clarify dynamic mapping for hashicorp_vault.metrics #2994

merged 1 commit into from
Apr 4, 2022

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Apr 4, 2022 •
edited
Loading

What does this PR do?

Remove named mappings and depend on the dynamic mappings. Dynamic mappings
were already present, but elastic-package doesn't honor those during field validation.
So this specifies a hashicorp_vault.metrics.*.* mapping for the express purpose of making
elastic-package field validation pass.

Fixes #2898

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@andrewkroh andrewkroh added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:hashicorp_vault Hashicorp Vault labels Apr 4, 2022
@andrewkroh andrewkroh requested a review from a team as a code owner April 4, 2022 20:48
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh
Clarify dynamic mapping for hashicorp_vault.metrics
55aff62 
Remove named mappings and depend on the dynamic mappings. Dynamic mappings
were already present, but elastic-package doesn't honor those during field validation.
So this specifies a hashicorp_vault.metrics.*.* mapping for the express purpose of making
elastic-package field validation pass.

Fixes elastic#2898
@andrewkroh andrewkroh force-pushed the hashicorp_vault/bugfix/dynamic-metric-fields branch from 331e9b8 to 55aff62 Compare April 4, 2022 20:49
@elasticmachine
Copy link

elasticmachine commented Apr 4, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-04T20:49:55.123+0000

  • Duration: 17 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 18
Skipped 0
Total 18

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@andrewkroh andrewkroh merged commit acfb43c into elastic:main Apr 4, 2022
This was referenced Apr 5, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working, use only for issues Integration:hashicorp_vault Hashicorp Vault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[hashicorp_vault] undefined metric fields detected by tests
3 participants
@andrewkroh @elasticmachine @efd6