-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[crowdstrike] Create FDR and SIEM Connector policy templates #2806
[crowdstrike] Create FDR and SIEM Connector policy templates #2806
Conversation
💔 Build Failed
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
|
This creates two new integrations in Fleet. One specifically for Falcon Data Replicator and one for Falcon SIEM Connector. These already existed in the "CrowdStrike" integration, but now they will also be listed on their own from the Fleet integration pages to make them more discoverable to users. There will still be a "CrowdStrike Logs" integration that contains inputs for all both FDR and the SIEM connector. This is similar to how the AWS integration contains inputs from all of the individual AWS services. This also removes the logfile input from the FDR data stream since it is not usable given the FDR tool writes gzip compressed files to disk. Only the AWS S3 input will be available. This addresses elastic#2194.
Upgrades are broken. The error is { "type": "log", "@timestamp": "2022-03-09T22:04:23+00:00", "tags": [ "info", "plugins", "fleet" ], "pid": 7, "package_policy_upgrade": { "package_name": "crowdstrike", "current_version": "1.2.3", "new_version": "1.3.2", "status": "failure", "error": [ { "key": "inputs.crowdstrike_fdr-aws-s3.streams.crowdstrike.fdr.vars.queue_url", "message": [ "Queue URL is required" ] } ], "dryRun": true }, "message": "Package policy upgrade dry run resulted in errors {\"package_policy_upgrade\":{\"package_name\":\"crowdstrike\",\"current_version\":\"1.2.3\",\"new_version\":\"1.3.2\",\"status\":\"failure\",\"error\":[{\"key\":\"inputs.crowdstrike_fdr-aws-s3.streams.crowdstrike.fdr.vars.queue_url\",\"message\":[\"Queue URL is required\"]}],\"dryRun\":true}}" }
This reverts commit 46cff5c.
I tested with 8.3.2 and it works when upgrading from 1.4.1 to 1.5.0 (this version). With 7.17.6-SNAPHOT it fails during the policy upgrade with Error: Root value is not flatten-able, received undefined
449af55
to
ad5807b
Compare
This no longer fails on 8.3.2, but it still failing on 7.17.6-SNAPSHOT with the same error. |
b8e5567
to
ad5807b
Compare
🌐 Coverage report
|
Failing tests are blocked on elastic/elastic-package#904. |
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution! |
DRAFT: Integration upgrades are not working.
What does this PR do?
This creates two new integrations in Fleet. One specifically for Falcon Data Replicator
and one for Falcon SIEM Connector. These already existed in the "CrowdStrike"
integration, but now they will also be listed on their own from the Fleet integration
pages to make them more discoverable to users.
There will still be a "CrowdStrike Logs" integration that contains inputs for all both
FDR and the SIEM connector. This is similar to how the AWS integration contains
inputs from all of the individual AWS services.
This also removes the logfile input from the FDR data stream since it is not usable
given the FDR tool writes gzip compressed files to disk. Only the AWS S3 input will
be available. This addresses #2194.
Checklist
changelog.yml
file.Related issues
Screenshots
Falcon SIEM Connector
FDR
Upgrade Error