Fix: use text type instead of integer (earlier: duration) #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference: elastic/package-spec#44 |
💚 Build Succeeded
Expand to view the summary
Build stats
|
ruflin
approved these changes
Sep 10, 2020
| - name: socket.reverse_lookup.failure_ttl | ||
| type: integer | ||
| type: text |
There was a problem hiding this comment.
I assume the user will have to put in something like 10s here and that is why text and not integer is needed? Would be nice to have this in the description in the future.
There was a problem hiding this comment.
Fixed! I added a sample value to the description.
mtojek
changed the title
eyalkraft
pushed a commit
to build-security/integrations
that referenced
this pull request
Mar 30, 2022
* Fix: use text type instead of duration * Add sample value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes variable type for duration-like option (should be text instead of duration).
Checklist
Author's Checklist
How to test this PR locally
Related issues
Screenshots