Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCP] Add GCP Load Balancer Metricset #2308

Closed
wants to merge 2 commits into from
Closed

[GCP] Add GCP Load Balancer Metricset #2308

wants to merge 2 commits into from

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Dec 2, 2021 •
edited
Loading

What does this PR do?

Add GCP Load Balancer Metricset

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 changed the base branch from master to gcp-metrics December 2, 2021 23:39
@elasticmachine
Copy link

elasticmachine commented Dec 2, 2021 •
edited
Loading

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-12T17:33:32.754+0000

  • Duration: 3 min 38 sec

Steps errors 3

Expand to view the steps failures

Load a resource file from a shared library
  • Took 0 min 0 sec . View more details here
  • Description: approval-list/elastic/integrations.yml
Google Storage Download
  • Took 0 min 0 sec . View more details here
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/legoguy1000 return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/legoguy1000 : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/legoguy1000 : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@legoguy1000 legoguy1000 force-pushed the 490-gcp-loadbalancing branch from aa723ff to 1f30b02 Compare December 31, 2021 16:23
@legoguy1000 legoguy1000 marked this pull request as ready for review December 31, 2021 16:32
@legoguy1000
Copy link
Contributor Author

@endorama This PR should be GTG.

@legoguy1000
Copy link
Contributor Author

@endorama I didn't mean to let this go, I will fix the conflicts so we can get these going.

@legoguy1000 legoguy1000 force-pushed the 490-gcp-loadbalancing branch 3 times, most recently from 6c4d1f4 to 5ffe6a0 Compare February 4, 2022 02:59
@legoguy1000
Copy link
Contributor Author

@endorama Ready for ur review.

@andrewkroh andrewkroh added the Integration:gcp Google Cloud Platform label Feb 11, 2022
@endorama endorama mentioned this pull request Feb 16, 2022
Merged
4 tasks
@endorama endorama mentioned this pull request Mar 2, 2022
Closed
11 tasks
@legoguy1000 legoguy1000 requested review from a team as code owners March 17, 2022 17:01
@endorama endorama force-pushed the gcp-metrics branch 3 times, most recently from 8cf80ec to fe54af3 Compare March 22, 2022 15:14
@legoguy1000 legoguy1000 force-pushed the 490-gcp-loadbalancing branch from 577dccd to b4bef8d Compare July 11, 2022 02:15
@legoguy1000
Copy link
Contributor Author

@endorama I rebased this branch and should be good to merge

endorama and others added 2 commits July 12, 2022 17:38
@endorama
update kibana constraint
edc3905 
Before version 8.3.0 a bug in the Fleet UI configuration conflict
resolution screen would prevent a successful update of this
package to the new version.

The constraint is updated on Kibana >= 8.3 where the related fix
landed[1] so we can guarantee a working upgrade path.

[1]: elastic/kibana#132068
@legoguy1000
[GCP] Add GCP Load Balancer Metricset
48eb65e
@legoguy1000 legoguy1000 force-pushed the 490-gcp-loadbalancing branch from c2f86f7 to 48eb65e Compare July 12, 2022 17:33
@endorama endorama deleted the branch elastic:gcp-metrics July 14, 2022 08:49
@endorama endorama closed this Jul 14, 2022
@endorama endorama mentioned this pull request Jul 14, 2022
Closed
@andrewkroh andrewkroh mentioned this pull request Aug 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Integration:gcp Google Cloud Platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legoguy1000 @elasticmachine @endorama @andrewkroh