Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix Apache ML module manifest query to ignore frozen and cold tiers #2217

Merged

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Nov 25, 2021

What does this PR do?

The query defined in the json configuration files of anomaly detection modules are run to determine if the module is match for data in the selected index. These queries run over the full time range of the index so can potentially take a long time to return, particularly if searching over documents which are not in the hot or warm data tiers. This PR adds an extra condition to the query to ignore data from the cold and frozen tiers.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Related issues

elastic/kibana#116696

@peteharverson peteharverson added bug Something isn't working, use only for issues Integration:apache Apache HTTP Server labels Nov 25, 2021
@elasticmachine
Copy link

elasticmachine commented Nov 25, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 15 min 22 sec

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteharverson peteharverson merged commit d59ee11 into elastic:master Nov 25, 2021
@peteharverson peteharverson deleted the ml-apache-exclude-frozen-tier branch November 25, 2021 16:06
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
…ers (elastic#2217)

* [ML] Fix Apache ML module manifest query to ignore frozen and cold tiers

* [ML] Fix PR number in changelog.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:apache Apache HTTP Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants