Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crowdstrike] Add support to parse the custom notification format provided by Crowdstrike #2198

Merged
merged 5 commits into from
Nov 30, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Nov 19, 2021

What does this PR do?

Adds support for the custom format of the FDR SQS notifications.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Closes #2193

@elasticmachine
Copy link

elasticmachine commented Nov 19, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-30T17:14:37.175+0000

  • Duration: 16 min 36 sec

  • Commit: 74d5204

Test stats 🧪

Test Results
Failed 0
Passed 13
Skipped 0
Total 13

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@marc-gr marc-gr added bug Something isn't working, use only for issues Integration:crowdstrike CrowdStrike Team:Security-External Integrations labels Nov 19, 2021
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@marc-gr marc-gr requested a review from andrewkroh November 30, 2021 17:14
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-gr marc-gr merged commit 8e755b1 into elastic:master Nov 30, 2021
@marc-gr marc-gr deleted the fdr_parsing_script branch November 30, 2021 18:24
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:crowdstrike CrowdStrike
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[crowdstrike/fdr] Update aws-s3 input config to support custom SQS notification format
3 participants