Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tanium] Map extra fields, set event.kind for alerts #12055

Merged

Conversation

chrisberkhout
Copy link
Contributor

@chrisberkhout chrisberkhout commented Dec 10, 2024

Proposed commit message

[tanium] Map extra fields, set event.kind for alerts

- Map extra fields from the new default `threat_response` format.
- Set `event.kind` as a scalar not an array.
- Set `event.kind` to `alert` if an alert ID is present.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@chrisberkhout chrisberkhout added enhancement New feature or request Integration:tanium Tanium Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Dec 10, 2024
@chrisberkhout chrisberkhout self-assigned this Dec 10, 2024
@chrisberkhout chrisberkhout requested a review from a team as a code owner December 10, 2024 15:40
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Dec 10, 2024

🚀 Benchmarks report

Package tanium 👍(3) 💚(2) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
client_status 10638.3 5405.41 -5232.89 (-49.19%) 💔

To see the full report comment with /test benchmark fullreport

tag: set_event_kind_alert
field: event.kind
value: alert
if: "![null, ''].contains(ctx.tanium?.threat_response?.alert_id)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allocates.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to

if: ctx.tanium?.threat_response?.alert_id != null && ctx.tanium.threat_response.alert_id != ''

@chrisberkhout chrisberkhout requested a review from efd6 December 11, 2024 17:36
@chrisberkhout chrisberkhout force-pushed the tanium-threat-response-alert-kind branch from af1a09f to 79a1ae5 Compare December 12, 2024 09:19
@chrisberkhout chrisberkhout enabled auto-merge (squash) December 12, 2024 09:19
@chrisberkhout chrisberkhout merged commit 29e29a1 into elastic:main Dec 12, 2024
3 checks passed
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @chrisberkhout

@elastic-vault-github-plugin-prod

Package tanium - 1.12.0 containing this change is available at https://epr.elastic.co/package/tanium/1.12.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:tanium Tanium Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants