-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packages/prometheus: Upgrade to package format_version v3 #11988
Conversation
Nice to see that we did not have to exclude any checks in validaton.yml |
@elastic/obs-cloudnative-monitoring Could someone PTAL? Thank you! |
…ion to latest stable
Also upgraded to latest package-spec: https://github.com/elastic/package-spec/blob/9ad6feb0a29d607f3a1186a41a8d28b82be4dd4b/spec/changelog.yml#L21 i.e., 3.3.0 |
💚 Build Succeeded
History
cc @shmsr |
Quality Gate passedIssues Measures |
LGTM! |
@gizas Makes sense. I should've put it. So for testing I have all the elastic-package tests (e.g., pipeline, static, etc.), and also linting to check for validations (SRV...). Everything looks good. I did basic testing by scraping data from Prometheus Server itself and populated the dashboard. I'll put the pics here: I have also updated the PR description. |
Package prometheus - 1.21.0 containing this change is available at https://epr.elastic.co/package/prometheus/1.21.0/ |
Proposed commit message
Upgrade to package format_version v3. Tested using elastic-package (pipeline, static, etc.) and also linting and building. Also did basic testing by scraping data from Prometheus Server itself and populating the dashboard. Works as expected. For testing, I used 8.16.1 cluster.
Checklist
changelog.yml
file.Related issues
#8028
Screenshots
Dashboards screenshots after using collector to scrape metrics from Prometheus Server itself.