-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checkpoint_email,okta,wiz: add support for request trace deletion #11954
Conversation
Filebeat v8.15.x added the ability to delete request traces on the agent's host. This change adds support for this feature to integrations with kibana.version at or above v8.15.x.
0832520
to
6f85d80
Compare
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
event |
2724.8 | 2074.69 | -650.11 (-23.86%) | 💔 |
Package wiz
👍(2) 💚(1) 💔(1)
Expand to view
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
issue |
2762.43 | 2132.2 | -630.23 (-22.81%) | 💔 |
To see the full report comment with /test benchmark fullreport
💚 Build Succeeded
cc @efd6 |
Quality Gate passedIssues Measures |
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The opt-in flow discussed in the beats change doesn't apply here. If there are old traces but tracing isn't currently enabled, when the integration is updated to this version it will delete old traces. I think that's okay though.
Yeah, that was my intention here. This should wipe all traces that it knows belong to it. |
Package checkpoint_email - 0.2.0 containing this change is available at https://epr.elastic.co/package/checkpoint_email/0.2.0/ |
Package okta - 3.1.0 containing this change is available at https://epr.elastic.co/package/okta/3.1.0/ |
Package wiz - 2.4.0 containing this change is available at https://epr.elastic.co/package/wiz/2.4.0/ |
Proposed commit message
Filebeat v8.15.x added the ability to delete request traces on the agent's host[1]. This change adds support for this feature to integrations with kibana.version at or above v8.15.x.
[1]elastic/beats#39969 and elastic/beats#40004
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots