Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkpoint_email,okta,wiz: add support for request trace deletion #11954

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Dec 2, 2024

Proposed commit message

Filebeat v8.15.x added the ability to delete request traces on the agent's host[1]. This change adds support for this feature to integrations with kibana.version at or above v8.15.x.

[1]elastic/beats#39969 and elastic/beats#40004

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:okta Okta Integration:wiz Wiz Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] Integration:checkpoint_email Check Point Harmony Email & Collaboration labels Dec 2, 2024
@efd6 efd6 self-assigned this Dec 2, 2024
Filebeat v8.15.x added the ability to delete request traces on the agent's host.
This change adds support for this feature to integrations with kibana.version at
or above v8.15.x.
@efd6 efd6 force-pushed the request_trace_deletes branch from 0832520 to 6f85d80 Compare December 2, 2024 22:10
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

Package checkpoint_email 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
event 2724.8 2074.69 -650.11 (-23.86%) 💔

Package wiz 👍(2) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
issue 2762.43 2132.2 -630.23 (-22.81%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

@efd6 efd6 marked this pull request as ready for review December 2, 2024 22:40
@efd6 efd6 requested a review from a team as a code owner December 2, 2024 22:40
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@chrisberkhout chrisberkhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The opt-in flow discussed in the beats change doesn't apply here. If there are old traces but tracing isn't currently enabled, when the integration is updated to this version it will delete old traces. I think that's okay though.

@efd6
Copy link
Contributor Author

efd6 commented Dec 4, 2024

Yeah, that was my intention here. This should wipe all traces that it knows belong to it.

@efd6 efd6 merged commit a82cf1b into elastic:main Dec 4, 2024
5 checks passed
@elastic-vault-github-plugin-prod

Package checkpoint_email - 0.2.0 containing this change is available at https://epr.elastic.co/package/checkpoint_email/0.2.0/

@elastic-vault-github-plugin-prod

Package okta - 3.1.0 containing this change is available at https://epr.elastic.co/package/okta/3.1.0/

@elastic-vault-github-plugin-prod

Package wiz - 2.4.0 containing this change is available at https://epr.elastic.co/package/wiz/2.4.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:checkpoint_email Check Point Harmony Email & Collaboration Integration:okta Okta Integration:wiz Wiz Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants