Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] add missing ECS mappings to wiz cdr_latest_vulnerabilities destination index #11614

Merged

Conversation

maxcold
Copy link
Contributor

@maxcold maxcold commented Nov 1, 2024

Proposed commit message

observer.vendor and cloud.provider ECS mappings missing in the cdr vulnerability latest transform destination index

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@maxcold maxcold added enhancement New feature or request Team:Service-Integrations Label for the Service Integrations team Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture] Integration:wiz Wiz labels Nov 1, 2024
@maxcold maxcold requested review from CohenIdo and a team November 1, 2024 11:08
@maxcold maxcold requested a review from a team as a code owner November 1, 2024 11:08
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added the Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] label Nov 1, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit then lgtm

packages/wiz/changelog.yml Outdated Show resolved Hide resolved
@maxcold maxcold requested a review from efd6 November 4, 2024 09:24
@elasticmachine
Copy link

💚 Build Succeeded

History

@maxcold maxcold merged commit efe5bce into elastic:main Nov 4, 2024
5 checks passed
@maxcold maxcold deleted the csp-add-missing-mappings-wiz-cdr-vulnerability branch November 4, 2024 12:19
maxcold added a commit to elastic/kibana that referenced this pull request Nov 4, 2024
## Summary

It closes elastic/security-team#11034

This PR removes runtime mappings for vulnerabilities, since they will be
added on the third party integration on [this
PR](elastic/integrations#11614) before the 8.16
release, we can remove the runtime mappings in Kibana in favour of not
compromising performance.

Co-authored-by: Maxim Kholod <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2024
## Summary

It closes elastic/security-team#11034

This PR removes runtime mappings for vulnerabilities, since they will be
added on the third party integration on [this
PR](elastic/integrations#11614) before the 8.16
release, we can remove the runtime mappings in Kibana in favour of not
compromising performance.

Co-authored-by: Maxim Kholod <[email protected]>
(cherry picked from commit 10d7926)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2024
## Summary

It closes elastic/security-team#11034

This PR removes runtime mappings for vulnerabilities, since they will be
added on the third party integration on [this
PR](elastic/integrations#11614) before the 8.16
release, we can remove the runtime mappings in Kibana in favour of not
compromising performance.

Co-authored-by: Maxim Kholod <[email protected]>
(cherry picked from commit 10d7926)
@elastic-vault-github-plugin-prod

Package wiz - 2.1.0 containing this change is available at https://epr.elastic.co/search?package=wiz

kibanamachine added a commit to elastic/kibana that referenced this pull request Nov 4, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [Reducing vulnerability runtime mappings
(#198739)](#198739)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Paulo
Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T14:00:35Z","message":"Reducing
vulnerability runtime mappings (#198739)\n\n## Summary\r\n\r\nIt closes
https://github.com/elastic/security-team/issues/11034\r\n\r\nThis PR
removes runtime mappings for vulnerabilities, since they will
be\r\nadded on the third party integration on
[this\r\nPR](elastic/integrations#11614) before
the 8.16\r\nrelease, we can remove the runtime mappings in Kibana in
favour of not\r\ncompromising performance.\r\n\r\nCo-authored-by: Maxim
Kholod
<[email protected]>","sha":"10d7926e3b2a943250d0ec2437c8d645486b84bd","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud
Security","v8.16.0","backport:version","v8.17.0"],"title":"Reducing
vulnerability runtime
mappings","number":198739,"url":"https://github.com/elastic/kibana/pull/198739","mergeCommit":{"message":"Reducing
vulnerability runtime mappings (#198739)\n\n## Summary\r\n\r\nIt closes
https://github.com/elastic/security-team/issues/11034\r\n\r\nThis PR
removes runtime mappings for vulnerabilities, since they will
be\r\nadded on the third party integration on
[this\r\nPR](elastic/integrations#11614) before
the 8.16\r\nrelease, we can remove the runtime mappings in Kibana in
favour of not\r\ncompromising performance.\r\n\r\nCo-authored-by: Maxim
Kholod
<[email protected]>","sha":"10d7926e3b2a943250d0ec2437c8d645486b84bd"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198739","number":198739,"mergeCommit":{"message":"Reducing
vulnerability runtime mappings (#198739)\n\n## Summary\r\n\r\nIt closes
https://github.com/elastic/security-team/issues/11034\r\n\r\nThis PR
removes runtime mappings for vulnerabilities, since they will
be\r\nadded on the third party integration on
[this\r\nPR](elastic/integrations#11614) before
the 8.16\r\nrelease, we can remove the runtime mappings in Kibana in
favour of not\r\ncompromising performance.\r\n\r\nCo-authored-by: Maxim
Kholod
<[email protected]>","sha":"10d7926e3b2a943250d0ec2437c8d645486b84bd"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Paulo Silva <[email protected]>
kibanamachine added a commit to elastic/kibana that referenced this pull request Nov 4, 2024
# Backport

This will backport the following commits from `main` to `8.16`:
- [Reducing vulnerability runtime mappings
(#198739)](#198739)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Paulo
Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T14:00:35Z","message":"Reducing
vulnerability runtime mappings (#198739)\n\n## Summary\r\n\r\nIt closes
https://github.com/elastic/security-team/issues/11034\r\n\r\nThis PR
removes runtime mappings for vulnerabilities, since they will
be\r\nadded on the third party integration on
[this\r\nPR](elastic/integrations#11614) before
the 8.16\r\nrelease, we can remove the runtime mappings in Kibana in
favour of not\r\ncompromising performance.\r\n\r\nCo-authored-by: Maxim
Kholod
<[email protected]>","sha":"10d7926e3b2a943250d0ec2437c8d645486b84bd","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud
Security","v8.16.0","backport:version","v8.17.0"],"title":"Reducing
vulnerability runtime
mappings","number":198739,"url":"https://github.com/elastic/kibana/pull/198739","mergeCommit":{"message":"Reducing
vulnerability runtime mappings (#198739)\n\n## Summary\r\n\r\nIt closes
https://github.com/elastic/security-team/issues/11034\r\n\r\nThis PR
removes runtime mappings for vulnerabilities, since they will
be\r\nadded on the third party integration on
[this\r\nPR](elastic/integrations#11614) before
the 8.16\r\nrelease, we can remove the runtime mappings in Kibana in
favour of not\r\ncompromising performance.\r\n\r\nCo-authored-by: Maxim
Kholod
<[email protected]>","sha":"10d7926e3b2a943250d0ec2437c8d645486b84bd"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198739","number":198739,"mergeCommit":{"message":"Reducing
vulnerability runtime mappings (#198739)\n\n## Summary\r\n\r\nIt closes
https://github.com/elastic/security-team/issues/11034\r\n\r\nThis PR
removes runtime mappings for vulnerabilities, since they will
be\r\nadded on the third party integration on
[this\r\nPR](elastic/integrations#11614) before
the 8.16\r\nrelease, we can remove the runtime mappings in Kibana in
favour of not\r\ncompromising performance.\r\n\r\nCo-authored-by: Maxim
Kholod
<[email protected]>","sha":"10d7926e3b2a943250d0ec2437c8d645486b84bd"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Paulo Silva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:wiz Wiz Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture] Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants