-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Nginx Ingress Controller Otel integration #11285
Conversation
dd8173f
to
063dded
Compare
8dc895f
to
27542ab
Compare
Is there a way to remove the "Add Nginx Ingress Controller OpenTelemetry Logs integration" button? (deployment mode) |
@@ -288,6 +288,7 @@ | |||
/packages/network_traffic @elastic/sec-linux-platform | |||
/packages/nginx @elastic/obs-infraobs-integrations | |||
/packages/nginx_ingress_controller @elastic/obs-cloudnative-monitoring | |||
/packages/nginx_ingress_controller_otel @elastic/obs-infraobs-integrations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit fuzzy. The non-otel integration is elastic/obs-cloudnative-monitoring
but this is obs-infraobs-integrations
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding @bturquet for any suggestions, I am ok with either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with both too. If it is helpful for you, I could additionally add myself as a codowner until Otel integrations become more stable.
@rogercoll : It has build failures: | 1. item [collector-config.yaml] is not allowed in folder [/opt/buildkite-agent/builds/bk-agent-prod-gcp-1728919549244574433/elastic/integrations/packages/nginx_ingress_controller_otel] I think since elastic package doesn't expect collector-config.yaml to be present. It is throwing an error. We will have to see how we can place this collector config. Or we should change the elastic package spec to have this addition. Please check for the 2nd error as well. |
Quality Gate passedIssues Measures |
💚 Build Succeeded
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @ishleenk17, I think those were fixed on the latest comment |
Looks good! |
Also, for now I see we are moving the configuration to the README. |
Correct, I was not able to add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Package nginx_ingress_controller_otel - 0.0.1 containing this change is available at https://epr.elastic.co/search?package=nginx_ingress_controller_otel |
Proposed commit message
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Unit testing
/tmp
directory instead:Related issues
Screenshots