-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iptables] Fix failing test daily: system test: journald in iptables.log #10883
Conversation
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
🚀 Benchmarks reportTo see the full report comment with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding config to drop this field entirely until the input is sorted out?
Like a beat processor is what I was thinking:
- drop_fields:
ignore_missing: true
fields:
- journald.custom.realtime_timestamp
We could do that with the processor, but the filebeat would need to be fixed before 8.16 release anyways I think. As far as I understand this approach would fail if the user upgrades to 8.16 filebeat without updating the package and rolling out the agent policy (that includes this drop_fields processor). So there is a chance that the beat would be still sending that field to Elasticsearch. |
True, neither solution addresses the problem of the user upgrading the agent before upgrading the package. Putting a The reason I prefer field deletion over adding a mapping is because when we no longer need this change and can revert it, then will look less like we are making a breaking change. |
Sounds good. Will add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting a
remove
processor into ingest pipeline is good mix of the two.
Sounds good. Will add
remove
processor.
added
drop_fields
processor as agreed
I think we got our wires crossed 😄 . I meant an ingest node pipeline remove
processor (https://www.elastic.co/guide/en/elasticsearch/reference/current/remove-processor.html). This marginally better than drop_fields
since it would cover cases like standalone agent where the user might not immediately update their edge configuration agent policy similar to what you mentioned.
e.g.
# packages/iptables/data_stream/log/elasticsearch/ingest_pipeline/default.yml
- remove:
description: Temporary fix to remove realtime_timestamp until the journald input is fixed.
if: ctx.agent?.version != null && ctx.agent.version.startsWith("8.16")
field: journald.custom.realtime_timestamp
ignore_missing: true
But given that this is meant to be very temporary, what you have is totally fine with me. I expect we'll have the input updated long before 8.16 is released.
Updated. |
Quality Gate passedIssues Measures |
💚 Build Succeeded
History
cc @aleksmaus |
I guess we would not need this change at all if the fix is upstream (in the filebeat), instead would have to add the mapping for the realtime_timestamp |
Closing this PR for the fix upstream (in filebeat) |
Proposed commit message
[iptables] Fix failing test daily: system test: journald in iptables.log
The latest version of filebeat sends the new field
journald.custom.realtime_timestamp
that didn't have mapping defined. Adding the mapping resolves the issue.Example:
The "auto-mapping" that was created for the index
I'm not 100% sure if this field should present in the first place, but adding the mapping fixes the test failure.
@andrewkroh @taylor-swanson
Checklist
changelog.yml
file.Related issues