-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iptables] Regenerate test expectations #10871
Conversation
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
💔 Build Failed
Failed CI StepsHistorycc @aleksmaus |
Quality Gate passedIssues Measures |
Hmm, it's odd, it fails in CI now with these regenerated files, while it passes against the snapshots of 8.14, 8.15, 8.16 that you get with the cloud deployment.
@andrewkroh @taylor-swanson How do you guys go about reproducing the exact environment for geoip processors, so you can get the proper test expectations generated that line up? |
elastic-package is supposed to setup ES with a custom DB to ensure reproducibility. Did something change where this DB is not be loaded properly? https://github.com/elastic/elastic-package/blob/main/docs/howto/ingest_geoip.md If the change is only affecting test files (no user facing changes) then we shouldn't need to make a release, so could omit the manifest/changelog edits. |
changes: | ||
- description: Regenarate geoip related tests expectations | ||
type: bugfix | ||
link: https://github.com/elastic/integrations/pull/8888888 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link: https://github.com/elastic/integrations/pull/8888888 | |
link: https://github.com/elastic/integrations/pull/10871 |
Ahh, that's good to know. That explains why the different results, then. Don't see the same errors with the local tests runs. Will close this PR then and dig more for repro locally. |
Proposed commit message
Regenerate test expectations that are failing now.
Not even sure if we suppose to release the version of the package for this kind of thing. Will place the PR and will see what happens.
Checklist
changelog.yml
file.Related issues