Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iptables] Regenerate test expectations #10871

Closed
wants to merge 1 commit into from

Conversation

aleksmaus
Copy link
Member

Proposed commit message

Regenerate test expectations that are failing now.
Not even sure if we suppose to release the version of the package for this kind of thing. Will place the PR and will see what happens.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@aleksmaus aleksmaus added Integration:iptables Iptables Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Aug 25, 2024
@aleksmaus aleksmaus self-assigned this Aug 25, 2024
@aleksmaus aleksmaus requested a review from a team as a code owner August 25, 2024 22:59
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@aleksmaus
Copy link
Member Author

Tested on few latest versions of the stack, that's what we get for this IP resolution now

Image

While the test expectation was

-                "geo": {
-                    "continent_name": "Asia",
-                    "country_iso_code": "BT",
-                    "country_name": "Bhutan",
-                    "location": {
-                        "lat": 27.5,
-                        "lon": 90.5

@elasticmachine
Copy link

elasticmachine commented Aug 25, 2024

💔 Build Failed

Failed CI Steps

History

cc @aleksmaus

@aleksmaus
Copy link
Member Author

Hmm, it's odd, it fails in CI now with these regenerated files, while it passes against the snapshots of 8.14, 8.15, 8.16 that you get with the cloud deployment.

test case failed: Expected results are different from actual ones: --- want
+++ got
@@ -80,9 +80,15 @@
             },
             "source": {
                 "as": {
-                    "number": 35908,
-                    "organization": {
-                        "name": "VPLSNET"
+                    "number": 35908
+                },
+                "geo": {
+                    "continent_name": "Asia",
+                    "country_iso_code": "BT",
+                    "country_name": "Bhutan",
+                    "location": {
+                        "lat": 27.5,
+                        "lon": 90.5

@andrewkroh @taylor-swanson How do you guys go about reproducing the exact environment for geoip processors, so you can get the proper test expectations generated that line up?

@andrewkroh
Copy link
Member

elastic-package is supposed to setup ES with a custom DB to ensure reproducibility. Did something change where this DB is not be loaded properly?

https://github.com/elastic/elastic-package/blob/main/docs/howto/ingest_geoip.md


If the change is only affecting test files (no user facing changes) then we shouldn't need to make a release, so could omit the manifest/changelog edits.

changes:
- description: Regenarate geoip related tests expectations
type: bugfix
link: https://github.com/elastic/integrations/pull/8888888
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link: https://github.com/elastic/integrations/pull/8888888
link: https://github.com/elastic/integrations/pull/10871

@aleksmaus
Copy link
Member Author

elastic-package is supposed to setup ES with a custom DB to ensure reproducibility. Did something change where this DB is not be loaded properly?

Ahh, that's good to know. That explains why the different results, then. Don't see the same errors with the local tests runs. Will close this PR then and dig more for repro locally.

@aleksmaus aleksmaus closed this Aug 25, 2024
@aleksmaus aleksmaus deleted the regen/iptables_geo_test branch August 25, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:iptables Iptables Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Stack 8.16.0-SNAPSHOT] [iptables] Failing test daily: system test: journald in iptables.log
3 participants