-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloud Security] implement cloud_security_finding data stream for Wiz #10790
[Cloud Security] implement cloud_security_finding data stream for Wiz #10790
Conversation
🚀 Benchmarks reportTo see the full report comment with |
packages/wiz/data_stream/cloud_configuration_finding/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/wiz/data_stream/cloud_configuration_finding/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/wiz/data_stream/cloud_configuration_finding/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/wiz/data_stream/cloud_configuration_finding/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
packages/wiz/data_stream/cloud_configuration_finding/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/wiz/data_stream/cloud_configuration_finding/fields/ecs.yml
Outdated
Show resolved
Hide resolved
packages/wiz/data_stream/cloud_configuration_finding/_dev/test/system/test-default-config.yml
Outdated
Show resolved
Hide resolved
packages/wiz/data_stream/cloud_configuration_finding/agent/stream/cel.yml.hbs
Show resolved
Hide resolved
packages/wiz/data_stream/cloud_configuration_finding/agent/stream/cel.yml.hbs
Show resolved
Hide resolved
@maxcold, would you be able to add a dashboard for this new datastream to improve integration quality and also add to screenshots? The CI seems to be failing on outdated |
💚 Build Succeeded
History
|
Quality Gate passedIssues Measures |
value: wiz.cloud_configuration_finding | ||
- name: '@timestamp' | ||
type: date | ||
description: Event timestamp. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the fields here are part of the ECS schema, I saw that also other integration mapped it manually but what is the reason for not using the ECS schema?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CohenIdo this is a good question. I indeed took it from the wiz.vulnerability
data stream. @kcreddy do you happen to know why to map these fields manually? Is it only because the ecs@mappings
were not there when the integration was first introduced?
Btw now when I think about it, we need to make data_stream.namespace
the type keyword
to support namespaces in our latest transform. Otherwise, the data from different namespaces would fail to be indexed in the latest index as per elastic/kibana#162889 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CohenIdo the fact that we need data_stream.namespace
to be just keyword
brings up a question for the vulnerability
data stream you work on, how to migrate from constant_keyword
to just keyword
as it will be a breaking change of the field mapping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, I think we should have constant_keyword
in the original mapping but add keyword
to the latest index mapping when working on the latest data stream. This way we should avoid validation error for the data_stream.namespace here on the original data stream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because the package expects these required fields to be defined, otherwise it fails in elastic-package build
https://github.com/elastic/package-spec/blob/main/code/go/internal/validator/semantic/validate_required_fields.go#L16-L25
Package wiz - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=wiz |
Proposed commit message
Implements a new data stream for Wiz, with Cloud Configuration Finding data.
Fixes:
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Running tests captured in the docs https://www.elastic.co/guide/en/integrations-developer/current/testing-and-validation.html
To test locally:
elastic-package build
elastic-package stack up -d -v
https://localhost:5601/
and install version of Wiz defined in the PR. Enable the new Cloud Configuration Finding data stream. For the Wiz credentials reach out to @maxcoldRelated issues
Screenshots