Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cyberarkpas] Update cyberarkpas to ECS 1.10.0 #1039

Merged
merged 7 commits into from
Jun 14, 2021

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented May 31, 2021

What does this PR do?

Updates package ECS version to 1.10.
Sync module changes to packages if any.
Adds Preserve Raw event functionality if not already exists.
Adds pipeline tests if missing.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Related issues

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@P1llus P1llus marked this pull request as draft May 31, 2021 15:35
@elasticmachine
Copy link

elasticmachine commented May 31, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Start Time: 2021-06-11T22:28:46.987+0000

  • Duration: 21 min 20 sec

  • Commit: e8f62c6

Test stats 🧪

Test Results
Failed 0
Passed 87
Skipped 0
Total 87

Trends 🧪

Image of Build Times

Image of Tests

@P1llus P1llus marked this pull request as ready for review June 4, 2021 11:34
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"severity": "Info",
"iso_timestamp": "2021-03-14T13:42:20Z",
"gateway_station": "10.0.1.20",
"raw": "\u003csyslog\u003e\n\n \u003caudit_record\u003e\n \u003cRfc5424\u003eyes\u003c/Rfc5424\u003e\n \u003cTimestamp\u003eMar 14 06:42:20\u003c/Timestamp\u003e\n \u003cIsoTimestamp\u003e2021-03-14T13:42:20Z\u003c/IsoTimestamp\u003e\n \u003cHostname\u003eVAULT\u003c/Hostname\u003e\n \u003cVendor\u003eCyber-Ark\u003c/Vendor\u003e\n \u003cProduct\u003eVault\u003c/Product\u003e\n \u003cVersion\u003e11.7.0000\u003c/Version\u003e\n \u003cMessageID\u003e124\u003c/MessageID\u003e\n \u003cDesc\u003eRename File\u003c/Desc\u003e\n \u003cSeverity\u003eInfo\u003c/Severity\u003e\n \u003cIssuer\u003eAdministrator\u003c/Issuer\u003e\n \u003cAction\u003eRename File\u003c/Action\u003e\n \u003cSourceUser\u003e\u003c/SourceUser\u003e\n \u003cTargetUser\u003e\u003c/TargetUser\u003e\n \u003cSafe\u003ePSM\u003c/Safe\u003e\n \u003cFile\u003eRoot\\Operating System-UnixSSH-34.123.103.115-PSMConnect\u003c/File\u003e\n \u003cStation\u003e127.0.0.1\u003c/Station\u003e\n \u003cLocation\u003e\u003c/Location\u003e\n \u003cCategory\u003e\u003c/Category\u003e\n \u003cRequestId\u003e\u003c/RequestId\u003e\n \u003cReason\u003e\u003c/Reason\u003e\n \u003cExtraDetails\u003e\u003c/ExtraDetails\u003e\n \u003cMessage\u003eRename File\u003c/Message\u003e\n \u003cGatewayStation\u003e10.0.1.20\u003c/GatewayStation\u003e\n \u003c/audit_record\u003e\n\n\u003c/syslog\u003e",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can drop this field given that we have the option of event.original?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would need to check with @adriansr as he was the one who added it, might be a reason around it?

Copy link
Contributor

@adriansr adriansr Jun 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, this field isn't there by default.

It's added by the XSLT for debugging purposes if necessary, to keep the original XML before the XSLT converts it to JSON.

It's added if you toggle this flag to 1:
https://github.com/elastic/beats/blob/d97155072907d26eaa27707c038161767245f6ff/x-pack/filebeat/module/cyberarkpas/_meta/assets/elastic-json-v1.0.xsl#L11

The test data was captured with this flag set as I had it enabled during development.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its safe to have it in the test data then, or I can remove it manually if needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will leave this in the testdata for now, the field itself won't be visible for end-users, but its good to have as a reference here.

@P1llus P1llus merged commit 41e5805 into elastic:master Jun 14, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
* updating cyberarkpas ECS version and adding pipeline tests

* updating cyberarkpas ECS version and adding pipeline tests

* linting and formatting, generating new test files and adding changelog/manifest changes

* Linting processors

* updating docs

* linting

* More linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.14 candidate enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants