-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding docs for leader election timings #635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gizas
requested review from
ChrsMark,
MichaelKatsoulis,
tetianakravchenko and
constanca-m
October 31, 2023 12:54
This pull request does not have a backport label. Could you fix it @gizas? 🙏
|
7 tasks
kilfoyle
reviewed
Oct 31, 2023
...management/elastic-agent/configuration/providers/kubernetes_leaderelection-provider.asciidoc
Outdated
Show resolved
Hide resolved
kilfoyle
reviewed
Oct 31, 2023
...management/elastic-agent/configuration/providers/kubernetes_leaderelection-provider.asciidoc
Outdated
Show resolved
Hide resolved
kilfoyle
reviewed
Oct 31, 2023
...management/elastic-agent/configuration/providers/kubernetes_leaderelection-provider.asciidoc
Outdated
Show resolved
Hide resolved
kilfoyle
reviewed
Oct 31, 2023
...management/elastic-agent/configuration/providers/kubernetes_leaderelection-provider.asciidoc
Outdated
Show resolved
Hide resolved
kilfoyle
reviewed
Oct 31, 2023
...management/elastic-agent/configuration/providers/kubernetes_leaderelection-provider.asciidoc
Outdated
Show resolved
Hide resolved
…s/kubernetes_leaderelection-provider.asciidoc Co-authored-by: David Kilfoyle <[email protected]>
…s/kubernetes_leaderelection-provider.asciidoc Co-authored-by: David Kilfoyle <[email protected]>
…s/kubernetes_leaderelection-provider.asciidoc Co-authored-by: David Kilfoyle <[email protected]>
…s/kubernetes_leaderelection-provider.asciidoc Co-authored-by: David Kilfoyle <[email protected]>
…s/kubernetes_leaderelection-provider.asciidoc Co-authored-by: David Kilfoyle <[email protected]>
kilfoyle
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
constanca-m
approved these changes
Nov 1, 2023
...management/elastic-agent/configuration/providers/kubernetes_leaderelection-provider.asciidoc
Outdated
Show resolved
Hide resolved
…s/kubernetes_leaderelection-provider.asciidoc Co-authored-by: Michael Katsoulis <[email protected]>
...management/elastic-agent/configuration/providers/kubernetes_leaderelection-provider.asciidoc
Outdated
Show resolved
Hide resolved
MichaelKatsoulis
approved these changes
Nov 3, 2023
…s/kubernetes_leaderelection-provider.asciidoc Co-authored-by: Michael Katsoulis <[email protected]>
tetianakravchenko
approved these changes
Nov 3, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 13, 2023
* Adding docs for leader election timings (cherry picked from commit ca3a091)
gizas
added a commit
that referenced
this pull request
Nov 13, 2023
* Adding docs for leader election timings (cherry picked from commit ca3a091) Co-authored-by: Andrew Gizas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the relevant documentation for the enhancement request of kubernetes Leader Election provider described elastic/elastic-agent#3625