Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that agent needs to be restarted if the upgrade happened via RPM or DEB #376

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

nimarezainia
Copy link
Contributor

Note that agent needs to be restarted if the upgrade happened via RPM or DEB

@mergify
Copy link
Contributor

mergify bot commented Aug 2, 2023

This pull request does not have a backport label. Could you fix it @nimarezainia? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Aug 2, 2023
@nimarezainia
Copy link
Contributor Author

@kilfoyle I am not sure if this is being mentioned elsewhere. Couldn't really find it.

Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Nima. I'll merge and backport this into the current docs.

I think this is the perfect spot to add the restart requirement. Eventually we'll need to have upgrade instructions in the docs, and when that happens (whenever I get to it) I'll make sure that the restart requirement is mentioned.

@kilfoyle kilfoyle merged commit 75fe2c4 into main Aug 2, 2023
1 check passed
mergify bot pushed a commit that referenced this pull request Aug 2, 2023
… or DEB (#376)

* Note that agent needs to be restarted if the upgrade happened via RPM/DEB

* Update docs/en/ingest-management/commands.asciidoc

---------

Co-authored-by: David Kilfoyle <[email protected]>
(cherry picked from commit 75fe2c4)
kilfoyle pushed a commit that referenced this pull request Aug 2, 2023
… or DEB (#376) (#382)

* Note that agent needs to be restarted if the upgrade happened via RPM/DEB

* Update docs/en/ingest-management/commands.asciidoc

---------

Co-authored-by: David Kilfoyle <[email protected]>
(cherry picked from commit 75fe2c4)

Co-authored-by: nima <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants