Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fleet-settings.asciidoc #303

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Update fleet-settings.asciidoc #303

merged 2 commits into from
Jul 4, 2023

Conversation

yomduf
Copy link
Contributor

@yomduf yomduf commented Jul 3, 2023

The official documentation isn't clear on the fact that it's not possible to have a single fleet server for several elasticsearch clusters So adding an Elasticsearch outputs different from the cluster to which the fleet server belongs is not possible.

@jrodewig jrodewig added Team:Docs documentation Improvements or additions to documentation labels Jul 3, 2023
@jrodewig jrodewig requested a review from kilfoyle July 3, 2023 13:47
@jrodewig
Copy link
Contributor

jrodewig commented Jul 3, 2023

@kilfoyle Can you take a look at this when you have a moment? If the review will require 2+ hrs, please feel free to add it to the current docs sprint or add it to the backlog for next. Thanks!

@kilfoyle kilfoyle marked this pull request as draft July 4, 2023 13:16
The official documentation isn't clear on the fact that it's not possible to have a single fleet server for several elasticsearch clusters
So adding an Elasticsearch outputs different from the cluster to which the fleet server belongs is not possible.
@kilfoyle kilfoyle changed the base branch from 8.8 to main July 4, 2023 13:19
@kilfoyle kilfoyle marked this pull request as ready for review July 4, 2023 13:19
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yomduf Thanks for opening this! It looks like a really important tip.
Screenshot 2023-07-04 at 9 24 42 AM

I've rebased the PR onto the main branch and added a small change to the text. I'll merge and backport into the current docs.

One small tip for next time you open a docs PR: After you click the edit button, in the URL that opens, you can switch 8.8, current or whatever branch to main, and that will make the PR much easier to merge.

For example, to update "Migrate from Beats to Elastic Agent", the edit button automatically opens this URL:
https://github.com/elastic/ingest-docs/edit/8.8/docs/en/ingest-management/migrate-beats-to-agent.asciidoc

So you can change that to:
https://github.com/elastic/ingest-docs/edit/main/docs/en/ingest-management/migrate-beats-to-agent.asciidoc

And then the PR can be merged directly into the docs after one of us writers approves it.

Thanks for helping keep the docs in good shape!

@kilfoyle
Copy link
Contributor

kilfoyle commented Jul 4, 2023

💚 All backports created successfully

Status Branch Result
8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kilfoyle pushed a commit to kilfoyle/ingest-docs that referenced this pull request Jul 4, 2023
* Update fleet-settings.asciidoc

The official documentation isn't clear on the fact that it's not possible to have a single fleet server for several elasticsearch clusters
So adding an Elasticsearch outputs different from the cluster to which the fleet server belongs is not possible.

* Small text update

---------

Co-authored-by: David Kilfoyle <[email protected]>
(cherry picked from commit e60173b)
@kilfoyle
Copy link
Contributor

kilfoyle commented Jul 4, 2023

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kilfoyle pushed a commit to kilfoyle/ingest-docs that referenced this pull request Jul 4, 2023
* Update fleet-settings.asciidoc

The official documentation isn't clear on the fact that it's not possible to have a single fleet server for several elasticsearch clusters
So adding an Elasticsearch outputs different from the cluster to which the fleet server belongs is not possible.

* Small text update

---------

Co-authored-by: David Kilfoyle <[email protected]>
(cherry picked from commit e60173b)
kilfoyle added a commit that referenced this pull request Jul 4, 2023
* Update fleet-settings.asciidoc

The official documentation isn't clear on the fact that it's not possible to have a single fleet server for several elasticsearch clusters
So adding an Elasticsearch outputs different from the cluster to which the fleet server belongs is not possible.

* Small text update

---------

Co-authored-by: David Kilfoyle <[email protected]>
(cherry picked from commit e60173b)

Co-authored-by: Guillaume Dufrenne <[email protected]>
kilfoyle added a commit that referenced this pull request Jul 4, 2023
* Update fleet-settings.asciidoc

The official documentation isn't clear on the fact that it's not possible to have a single fleet server for several elasticsearch clusters
So adding an Elasticsearch outputs different from the cluster to which the fleet server belongs is not possible.

* Small text update

---------

Co-authored-by: David Kilfoyle <[email protected]>
(cherry picked from commit e60173b)

Co-authored-by: Guillaume Dufrenne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Team:Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants