Update_kibana_full_to_use_new_homebrew_tap #152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to download kibana for elasticsearch using homebrew on an M1 mac resulted in this error: Calling plist_options is disabled! Use service.require_root instead. Please report this issue to the elastic/tap tap (not Homebrew/brew or Homebrew/homebrew-core), or even better, submit a PR to fix it: /opt/homebrew/Library/Taps/elastic/homebrew-tap/Formula/kibana-full.rb:50
This is the PR to fix it, as suggested by the prompt. The fix is simply substituting plist_options with service.require_root
This PR is inspired by a similar PR for mongoDb https://github.com/mongodb/homebrew-brew/pull/176/files
Kibana seems like a really cool visualization tool for my performance testing results and I want myself and future users to be able to leverage this tool.