Adjust installation test #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During installation, we start elasticsearch a couple of times and check that we can connect to it. Since elastic/elasticsearch#72300 this tests ( and installation for that matter) has been failing since security is enabled by default and we make requests without credentials. This change, as a temporary measure, makes it so that we start elasticsearch with security explicitly disabled temporarily during installation so that we can make the necessary connection test requests without credentials. In a follow-up, we will adjust the Formula to take advantage of newly added functionality, set and show the password for the elastic user during installation (similar to what we do in elastic/elasticsearch#75144). We can then also use this password to make the test requests without needing to disable authN.
|
@mgreau just making sure this is on your radar so that we can merge soon and unblock tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During installation, we start elasticsearch a couple of times and
check that we can connect to it. Since elastic/elasticsearch#72300
these tests ( and installation for that matter) have been failing
since security is enabled by default and we make requests without
credentials.
This change, as a temporary measure, makes it so that we start
elasticsearch with security explicitly disabled temporarily during
installation so that we can make the necessary connection test
requests without credentials.
In a follow-up, we will adjust the Formula to take advantage of
newly added functionality, set and show the password for the
elastic user during installation (similar to what we do in
elastic/elasticsearch#75144). We can then also use this password
to make the test requests without needing to disable authN.