This repository has been archived by the owner on May 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[filebeat] add permission to list nodes #704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
I actually missed explaining why this is needed: In order to add extra metadata: |
jmlrt
approved these changes
Jul 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM⛴
jenkins test this please |
cla/check |
jmlrt
changed the title
added permission to list nodes
[filebeat] add permission to list nodes
Jul 2, 2020
jmlrt
pushed a commit
that referenced
this pull request
Jul 2, 2020
This commit add permission to list nodes. This is required when using `add_resource_metadata: node.enabled: true`.
jmlrt
pushed a commit
that referenced
this pull request
Jul 2, 2020
This commit add permission to list nodes. This is required when using `add_resource_metadata: node.enabled: true`.
jmlrt
pushed a commit
that referenced
this pull request
Jul 2, 2020
This commit add permission to list nodes. This is required when using `add_resource_metadata: node.enabled: true`.
backported to |
Closed
This was referenced Nov 17, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${CHART}/tests/*.py
${CHART}/examples/*/test/goss.yaml
Fix #703