Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[filebeat] add permission to list nodes #704

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

bmilescu
Copy link
Contributor

@bmilescu bmilescu commented Jul 1, 2020

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Fix #703

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@bmilescu
Copy link
Contributor Author

bmilescu commented Jul 1, 2020

I actually missed explaining why this is needed:
#703

In order to add extra metadata:
add_resource_metadata: node.enabled: true

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴

@jmlrt
Copy link
Member

jmlrt commented Jul 2, 2020

jenkins test this please

@jmlrt
Copy link
Member

jmlrt commented Jul 2, 2020

cla/check

@jmlrt jmlrt added enhancement New feature or request filebeat labels Jul 2, 2020
@jmlrt jmlrt changed the title added permission to list nodes [filebeat] add permission to list nodes Jul 2, 2020
@jmlrt jmlrt merged commit 75263dd into elastic:master Jul 2, 2020
jmlrt pushed a commit that referenced this pull request Jul 2, 2020
This commit add permission to list nodes. 
This is required when using `add_resource_metadata: node.enabled: true`.
jmlrt pushed a commit that referenced this pull request Jul 2, 2020
This commit add permission to list nodes. 
This is required when using `add_resource_metadata: node.enabled: true`.
jmlrt pushed a commit that referenced this pull request Jul 2, 2020
This commit add permission to list nodes. 
This is required when using `add_resource_metadata: node.enabled: true`.
@jmlrt
Copy link
Member

jmlrt commented Jul 2, 2020

backported to 6.8, 7.8and 7.x branches

This was referenced Jul 16, 2020
This was referenced Jul 27, 2020
@jmlrt jmlrt mentioned this pull request Oct 28, 2020
This was referenced Nov 17, 2020
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
This was referenced Mar 15, 2021
@jmlrt jmlrt mentioned this pull request May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filebeat deployment in k8s failes to list nodes
3 participants