Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[filebeat] document probe workaround for kafka output #699

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

jmlrt
Copy link
Member

@jmlrt jmlrt commented Jun 29, 2020

This commit document the workaround to work with Filebeat output which don't support testing.

This is required as the default readiness probe use filebeat test output command.

Fixes #694

This commit document the workaround to work with Filebeat output which don't support testing.

This is required as the default readiness probe use `filebeat test output` command.
Copy link
Contributor

@Conky5 Conky5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- -c
- |
#!/usr/bin/env bash -e
curl --fail 127.0.0.1:5066
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this is wrapped in sh and then bash, I think it could just be

readinessProbe:
  exec:
    command:
      - curl
      - --fail
      - 127.0.0.1:5066

But I do see this matches the existing probes so it's a discussion for somewhere else.

@jmlrt jmlrt merged commit b375f8f into elastic:master Jul 8, 2020
@jmlrt jmlrt deleted the faq-readiness-probe-output branch July 8, 2020 17:36
jmlrt added a commit that referenced this pull request Jul 8, 2020
This commit document the workaround to work with Filebeat output which don't support testing.

This is required as the default readiness probe use `filebeat test output` command.
jmlrt added a commit that referenced this pull request Jul 8, 2020
This commit document the workaround to work with Filebeat output which don't support testing.

This is required as the default readiness probe use `filebeat test output` command.
jmlrt added a commit that referenced this pull request Jul 8, 2020
This commit document the workaround to work with Filebeat output which don't support testing.

This is required as the default readiness probe use `filebeat test output` command.
@jmlrt
Copy link
Member Author

jmlrt commented Jul 8, 2020

backported to 6.8, 7.8and 7.x branches

This was referenced Jul 16, 2020
This was referenced Jul 27, 2020
@jmlrt jmlrt mentioned this pull request Oct 28, 2020
This was referenced Nov 17, 2020
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
This was referenced Mar 15, 2021
@jmlrt jmlrt mentioned this pull request May 25, 2021
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
This was referenced Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filebeat to kafka output does not work
2 participants