This repository has been archived by the owner on May 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[filebeat] document probe workaround for kafka output #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit document the workaround to work with Filebeat output which don't support testing. This is required as the default readiness probe use `filebeat test output` command.
Conky5
approved these changes
Jul 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- -c | ||
- | | ||
#!/usr/bin/env bash -e | ||
curl --fail 127.0.0.1:5066 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why this is wrapped in sh
and then bash
, I think it could just be
readinessProbe:
exec:
command:
- curl
- --fail
- 127.0.0.1:5066
But I do see this matches the existing probes so it's a discussion for somewhere else.
jmlrt
added a commit
that referenced
this pull request
Jul 8, 2020
This commit document the workaround to work with Filebeat output which don't support testing. This is required as the default readiness probe use `filebeat test output` command.
jmlrt
added a commit
that referenced
this pull request
Jul 8, 2020
This commit document the workaround to work with Filebeat output which don't support testing. This is required as the default readiness probe use `filebeat test output` command.
jmlrt
added a commit
that referenced
this pull request
Jul 8, 2020
This commit document the workaround to work with Filebeat output which don't support testing. This is required as the default readiness probe use `filebeat test output` command.
backported to |
Closed
This was referenced Nov 17, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit document the workaround to work with Filebeat output which don't support testing.
This is required as the default readiness probe use
filebeat test output
command.Fixes #694