-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[elasticsearch] Add support for NetworkPolicy. #498
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
7df9c1f
to
51bb6f4
Compare
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist. |
Up? |
Upvoting for NetworkPolicy, @desaintmartin thank you :) |
I can rebase if you are interested into this feature. ;) |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist. |
Not stale... Is this PR wanted? |
cc @jmlrt maybe ? |
Hi @desaintmartin, thanks for this PR. This is still something that we want to merge but don't have workload for a proper review and tests currently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @desaintmartin, sorry for the delay, I finally was able to review it.
This is mostly LGTM.
- Can you merge rebase on master to fix conflicts?
- The
networkpolicy
example may not be required if there is no tests specifics to network policies. we could remove thegoss.yaml
, but if the examples values are the same as commented example in default values, we may not need this example at all - Finally the python tests may need to be formatted using Black to pass CI tests
51bb6f4
to
ab882cb
Compare
Done! Let's see what the CI says. |
jenkins test this please |
💚 CLA has been signed |
Updated! |
jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM⛴
NetworkPolicy support would be a nice addition to this chart. Here is a implementation proposal, open to discussion, where I strictly separate http and transport ports.
${CHART}/tests/*.py
${CHART}/examples/*/test/goss.yaml