[elasticsearch] Reworked the way to mapping node roles. Node roles are mapped as "nod… #1057
Conversation
…e.roles" environment variable now.
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
maximchukm
changed the title
|
hello, tests are running fine? |
Hello, I've just checked it and updated couple assertions for a new environment variable. Now it's running fine. |
|
jenkins test this please |
|
Hi @maximchukm, thanks for this PR. Related to #855 |
# Conflicts: # elasticsearch/templates/statefulset.yaml # elasticsearch/tests/elasticsearch_test.py
There was a problem hiding this comment.
Hi @maximchukm, many thanks for your work on this PR 🙏🏻 .
I had some issues during review and tests and I had to rework the implementation which needed a bit more refactoring in #1186.
Sounds great, looking forward to using the new way of role setting! |
|
Closing as it was implemented in #1186 |
I had experienced a problem when I tried to set up nodes data tiers through "roles" parameter.
During ElasticSearch pod starting I had the error: "unknown setting [node.data_cold] please check that any required plugins are installed", as well as I found another message caused by the same way to set roles: "[node.master] setting was deprecated in Elasticsearch and will be removed in a future release!"
According to this, I reworked the node roles setting.