Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Commit

Permalink
Elasticsearch: do not include heritage selector (#437)
Browse files Browse the repository at this point in the history
According to https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md, service selector should not contain heritage.

It would break (future) migration from helm 2 to helm 3 (during the rolling update only, there could be a downtime when only old nodes are ready but new services is there).
  • Loading branch information
desaintmartin authored Jun 11, 2020
1 parent 4eceebc commit a8e8752
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion elasticsearch/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ metadata:
spec:
type: {{ .Values.service.type }}
selector:
heritage: {{ .Release.Service | quote }}
release: {{ .Release.Name | quote }}
chart: "{{ .Chart.Name }}"
app: "{{ template "elasticsearch.uname" . }}"
Expand Down

0 comments on commit a8e8752

Please sign in to comment.