Fix hang during init on Windows if WMI is unavailable #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue affected Windows Vista and newer. During the `init()` phase a WMI call was made to get the system boot time. If WMI wasn't fully up the call would hang which blocked the entire application from initializing.
exekias
reviewed
Jun 8, 2017
| @@ -82,7 +74,15 @@ func (self *ProcFDUsage) Get(pid int) error { | |||
| func (self *Uptime) Get() error { | |||
There was a problem hiding this comment.
I guess we don't have to worry about this being called concurrently?
There was a problem hiding this comment.
Since we can't guarantee how the library will be used I would feel more comfortable if it was concurrency-safe. I will make a change.
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Jun 12, 2017
Fixed Windows issue that caused a hang during `init()` if WMI wasn't ready. elastic/gosigar#74 Fixes elastic#4373
exekias
pushed a commit
to elastic/beats
that referenced
this pull request
Jun 13, 2017
* Update gosigar to fix Windows service timeout Fixed Windows issue that caused a hang during `init()` if WMI wasn't ready. elastic/gosigar#74 Fixes #4373
andrewkroh
added a commit
to andrewkroh/gosigar
that referenced
this pull request
Jun 13, 2017
Fix hang during init on Windows if WMI is unavailable This issue affected Windows Vista and newer. During the `init()` phase a WMI call was made to get the system boot time. If WMI wasn't fully up the call would hang which blocked the entire application from initializing.
tsg
pushed a commit
that referenced
this pull request
Jun 13, 2017
Fix hang during init on Windows if WMI is unavailable This issue affected Windows Vista and newer. During the `init()` phase a WMI call was made to get the system boot time. If WMI wasn't fully up the call would hang which blocked the entire application from initializing.
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Jun 13, 2017
Fixed Windows issue that caused a hang during `init()` if WMI wasn't ready. elastic/gosigar#74 elastic/gosigar#76 Fixes elastic#4373
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Jun 13, 2017
Fixed Windows issue that caused a hang during `init()` if WMI wasn't ready. elastic/gosigar#74 elastic/gosigar#76 Fixes elastic#4373
tsg
pushed a commit
to elastic/beats
that referenced
this pull request
Jun 14, 2017
Fixed Windows issue that caused a hang during `init()` if WMI wasn't ready. elastic/gosigar#74 elastic/gosigar#76 Fixes #4373
tsg
pushed a commit
to elastic/beats
that referenced
this pull request
Jun 14, 2017
Fixed Windows issue that caused a hang during `init()` if WMI wasn't ready. elastic/gosigar#74 elastic/gosigar#76 Fixes #4373
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Fixed Windows issue that caused a hang during `init()` if WMI wasn't ready. elastic/gosigar#74 elastic/gosigar#76 Fixes elastic#4373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue affected Windows Vista and newer. During the
init()phase a WMI call was made to get the system boot time. If WMI wasn't fully up the call would hang which blocked the entire application from initializing.