-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Go 1.16.3 #82
Conversation
💚 CLA has been signed |
💚 Build Succeeded
Expand to view the summary
Build stats
Trends 🧪 |
Hi, @michalpristas, can you please advise how I can get 1.16.x out? Appreciate your help. |
jenkins run tests |
Go 1.16.3 has been released in the meantime. Do you mind updating the PR? |
Hi sure
On Thu, Apr 29, 2021 at 8:27 AM Noémi Ványi ***@***.***> wrote:
Go 1.16.3 has been released in the meantime. Do you mind updating the PR?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#82 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAA7VRVKKQBXMQ47KEH2WTTLFGEHANCNFSM4ZPHRBLQ>
.
--
nhm tanveer hossain khan (hasan)
"work for fun"
|
Hi @kvch, I just pushed for 1.16.3. Please let me know how it goes. Thanks |
jenkins run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add go1.16
to the list of TARGETS
in Makefile
. Otherwise, your work is not built.
Thanks for updating the PR. |
@kvch thanks for the review, I just updated my PR. Thanks for looking into it. |
jenkins run tests |
Also, I have found two more places that has to be updated:
|
Let me address them now |
hi @kvch, thanks for your time. I have updated the PR with your requested changes. Let me know if you need anything else. Thanks |
jenkins run tests |
Thanks a lot. Looking forward to upgrading cross-build for newer go
On Mon, May 10, 2021 at 7:15 AM Noémi Ványi ***@***.***> wrote:
@we4tech <https://github.com/we4tech> Your work has been accepted in #85
<#85>. Unfortunately, at
the moment changes in the Jenkinsfile is not picked up from outside
contributors. Thus, we opened a new PR with your changes, added a minor fix
and merged it. Thank you so much for your contribution.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#82 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAA7VWNIWUON73S4HXZWQLTM6537ANCNFSM4ZPHRBLQ>
.
--
nhm tanveer hossain khan (hasan)
"work for fun"
|
Update crossbuild for Go
1.16.21.16.3