Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.16.3 #82

Closed
wants to merge 6 commits into from
Closed

Conversation

we4tech
Copy link
Contributor

@we4tech we4tech commented Mar 19, 2021

Update crossbuild for Go 1.16.2 1.16.3

@cla-checker-service
Copy link

cla-checker-service bot commented Mar 19, 2021

💚 CLA has been signed

@elasticmachine
Copy link

elasticmachine commented Mar 19, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by user Victor Martinez

  • Start Time: 2021-05-10T09:41:54.344+0000

  • Duration: 19 min 4 sec

  • Commit: 17e4e31

Trends 🧪

Image of Build Times

@we4tech
Copy link
Contributor Author

we4tech commented Mar 22, 2021

Hi, @michalpristas, can you please advise how I can get 1.16.x out?

Appreciate your help.

@ph ph requested a review from kvch April 19, 2021 18:55
@ph ph mentioned this pull request Apr 19, 2021
@ph ph mentioned this pull request Apr 27, 2021
5 tasks
@kvch
Copy link
Contributor

kvch commented Apr 29, 2021

jenkins run tests

@kvch
Copy link
Contributor

kvch commented Apr 29, 2021

Go 1.16.3 has been released in the meantime. Do you mind updating the PR?

@we4tech
Copy link
Contributor Author

we4tech commented Apr 29, 2021 via email

@we4tech we4tech changed the title Update to Go 1.16.2 Update to Go 1.16.3 Apr 29, 2021
@we4tech
Copy link
Contributor Author

we4tech commented Apr 29, 2021

Hi @kvch, I just pushed for 1.16.3. Please let me know how it goes. Thanks

@kvch
Copy link
Contributor

kvch commented May 4, 2021

jenkins run tests

Copy link
Contributor

@kvch kvch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add go1.16 to the list of TARGETS in Makefile. Otherwise, your work is not built.

@kvch
Copy link
Contributor

kvch commented May 4, 2021

Thanks for updating the PR.

@we4tech we4tech requested a review from kvch May 4, 2021 14:25
@we4tech
Copy link
Contributor Author

we4tech commented May 4, 2021

@kvch thanks for the review, I just updated my PR. Thanks for looking into it.

@kvch
Copy link
Contributor

kvch commented May 6, 2021

jenkins run tests

@kvch
Copy link
Contributor

kvch commented May 6, 2021

Also, I have found two more places that has to be updated:

@we4tech
Copy link
Contributor Author

we4tech commented May 6, 2021

Also, I have found two more places that has to be updated:

Let me address them now

@we4tech
Copy link
Contributor Author

we4tech commented May 6, 2021

hi @kvch, thanks for your time. I have updated the PR with your requested changes. Let me know if you need anything else. Thanks

@kvch
Copy link
Contributor

kvch commented May 10, 2021

jenkins run tests

@kvch
Copy link
Contributor

kvch commented May 10, 2021

@we4tech Your work has been accepted in #85. Unfortunately, at the moment changes in the Jenkinsfile is not picked up from outside contributors. Thus, we opened a new PR with your changes, added a minor fix and merged it. Thank you so much for your contribution.

@kvch kvch closed this May 10, 2021
@we4tech
Copy link
Contributor Author

we4tech commented May 10, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants