Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host: add os.type (OSInfo.Type) from ECS 1.8 #87

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Jan 13, 2021

Adds a Type field to OSInfo. Follows the ECS rules:

"Use the os.type field to categorize the operating system into one of the broad commercial families.

One of these following values should be used (lowercase):

  • linux
  • macos
  • unix
  • windows

If the OS you’re dealing with is not in the list, the field should not be populated."

Adds a Type field to OSInfo, to align with ECS 1.8. Follows the ECS
rules:

"Use the os.type field to categorize the operating system into one of
the broad commercial families.

One of these following values should be used (lowercase):
 - linux
 - macos
 - unix
 - windows

If the OS you’re dealing with is not in the list,
the field should not be populated.
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 13, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #87 updated

    • Start Time: 2021-01-13T17:53:38.990+0000
  • Duration: 4 min 19 sec

  • Commit: 0b4d7f1

Test stats 🧪

Test Results
Failed 0
Passed 50
Skipped 0
Total 50

@andresrc
Copy link

ping @elastic/integrations @elastic/agent

Copy link

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adriansr adriansr merged commit fe39609 into elastic:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants