provider/windows: minimal process provider #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a minimal process provider for Windows; just enough to support sysinfo.Self(). The resulting Process implements types.Memory and types.CPUTimer.
|
@andrewkroh with this, is there any reason to not embed CPUTimer and Memory in the Process interface? i.e. require all Processes to implement them? |
|
+1 for embedding them in |
All Processes now implement CPUTimer, so CPUTimer is embedded in the Process interface. Similarly, all Processes now implement Memory, so the Memory method is transferred to Process, and the Memory interface removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a minimal process provider for Windows; just enough to support sysinfo.Self().
All Processes now implement CPUTimer, so CPUTimer is embedded in the Process interface. Similarly,
all Processes now implement Memory, so the Memory method is transferred to Process, and the Memory interface removed.