Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace pkg/errors with Go 1.13 native errors #123

Merged
merged 3 commits into from
Jul 28, 2022
Merged

feat: replace pkg/errors with Go 1.13 native errors #123

merged 3 commits into from
Jul 28, 2022

Conversation

kruskall
Copy link
Member

Add support for error wrapping and switch to modern
Go 1.13 errors.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 28, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-28T18:52:03.727+0000

  • Duration: 34 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 92
Skipped 2
Total 94

@kruskall kruskall force-pushed the feat/replace-pkg-errors branch 2 times, most recently from 25435a3 to 6e22e29 Compare July 28, 2022 11:07
@kruskall
feat: replace pkg/errors with Go 1.13 native errors
1068c21 
Add support for error wrapping and switch to modern
Go 1.13 errors.
@kruskall kruskall force-pushed the feat/replace-pkg-errors branch from 6e22e29 to 1068c21 Compare July 28, 2022 11:29
andrewkroh
andrewkroh approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a CHANGELOG.md entry.

@kruskall
Copy link
Member Author

Please add a CHANGELOG.md entry.

Thank you for pointing this out! 🙇

@kruskall kruskall merged commit 44e5479 into elastic:main Jul 28, 2022
@kruskall kruskall deleted the feat/replace-pkg-errors branch July 28, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kruskall @elasticmachine @andrewkroh