replace readme string concat with json marshal #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just took a look after being a long time user of oliver/elastic-go and noticed a quite jarring promotion of string concatenation in the example for indexing a document. I don't think a database driver should be promoting usage of string concatenation. Someone is going to copy this into production and end up with an injection vulnerability or request smuggling issue. https://github.com/elastic/go-elasticsearch#usage <img width="398" alt="image" src="https://user-images.githubusercontent.com/5204642/167987969-ff1abe07-9f3b-499c-8a6c-1561a41ff5cf.png">
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
|
signed the cla |
|
Thank you @epelc for pointing that out and for the fix! I'd also like to highlight for future reader that json marshaling is not sufficient and users should sanitize their data before ingestion. LGTM! |
Anaethelion
pushed a commit
that referenced
this pull request
May 12, 2022
Anaethelion
pushed a commit
that referenced
this pull request
May 12, 2022
|
@Anaethelion Thanks for the quick merge! Excited to see potential support for request/response structs. Looking to switch over from oliver's driver eventually. |
Anaethelion
added a commit
that referenced
this pull request
May 12, 2022
Co-authored-by: Ed Pelc <[email protected]>
Anaethelion
added a commit
that referenced
this pull request
May 12, 2022
Co-authored-by: Ed Pelc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just took a look after being a long time user of oliver/elastic-go and noticed a quite jarring promotion of string concatenation in the example for indexing a document.
I don't think a database driver should be promoting usage of string concatenation. Someone is going to copy this into production and end up with an injection vulnerability or request smuggling issue.
https://github.com/elastic/go-elasticsearch#usage