The Delete By Query "slices" field cannot be set to "auto" #77
Comments
|
Hi, it seems like the REST API specification for this API lists the parameter as |
|
Hi @rliebz, it looks like the spec hasn't been updated yet. I'll have a look into that. |
|
Hey @karmi, any updates on this issue? I also came across this issue in my use case. This seems like a much needed fix. |
|
Hi, sorry, not news yet — I'll prioritize it for the next month. |
karmi
added a commit
to elastic/elasticsearch
that referenced
this issue
Jan 28, 2020
…ecification This patch updates the `type` parameter in the Delete By Query API: according to [the documentation](https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-delete-by-query.html#docs-delete-by-query-slice), it can be set to "auto", but the type in the documentation allows only numerical values. This prevents people from setting the parameter to "auto" eg. in the Go client, which generates source from the specification, and sets the corresponding Go type as number. The patch uses the `|` notation, which we have discussed previously for encoding a "polymorphic" parameter like this. Related: elastic/go-elasticsearch#77
karmi
added a commit
to elastic/elasticsearch
that referenced
this issue
Feb 2, 2020
…ecification (#51535) This patch updates the `type` parameter in the Delete By Query API: according to [the documentation](https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-delete-by-query.html#docs-delete-by-query-slice), it can be set to "auto", but the type in the documentation allows only numerical values. This prevents people from setting the parameter to "auto" eg. in the Go client, which generates source from the specification, and sets the corresponding Go type as number. The patch uses the `|` notation, which we have discussed previously for encoding a "polymorphic" parameter like this. Related: elastic/go-elasticsearch#77
karmi
added a commit
to elastic/elasticsearch
that referenced
this issue
Feb 2, 2020
…ecification (#51535) This patch updates the `type` parameter in the Delete By Query API: according to [the documentation](https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-delete-by-query.html#docs-delete-by-query-slice), it can be set to "auto", but the type in the documentation allows only numerical values. This prevents people from setting the parameter to "auto" eg. in the Go client, which generates source from the specification, and sets the corresponding Go type as number. The patch uses the `|` notation, which we have discussed previously for encoding a "polymorphic" parameter like this. Related: elastic/go-elasticsearch#77
karmi
added a commit
to elastic/elasticsearch
that referenced
this issue
Feb 2, 2020
* REST: Test: Fix the `accept_enterprise` parameter for Get License API (#51527) The Get License API specifies the `accept_enterprise` parameter as a `boolean`: https://github.com/elastic/elasticsearch/blob/0ca5cb8cb636a4be9c36b8e38e565af66abc423b/x-pack/plugin/src/test/resources/rest-api-spec/api/license.get.json#L22-L27 In the test, a `string` is passed however, which makes the test compilation fail in the Go client. (cherry picked from commit e2a2169) * Fix the SQL API documentation in REST specification (#51534) This patch fixes the SQL REST API documentation to conform to the current schema. (cherry picked from commit c8b6a84) * Fix the "slices" parameter for the Delete By Query API in the REST specification (#51535) This patch updates the `type` parameter in the Delete By Query API: according to [the documentation](https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-delete-by-query.html#docs-delete-by-query-slice), it can be set to "auto", but the type in the documentation allows only numerical values. This prevents people from setting the parameter to "auto" eg. in the Go client, which generates source from the specification, and sets the corresponding Go type as number. The patch uses the `|` notation, which we have discussed previously for encoding a "polymorphic" parameter like this. Related: elastic/go-elasticsearch#77 * Fix the Enrich API documentation in REST specification (#51528) This patch fixes the REST API documentation for the Enrich APIs to conform to the current schema. (cherry picked from commit 59f28f4)
|
Hello, this has been fixed in the REST API specification, and the field is takes "polymorphic" values on master: I'll have a look into backporting this into 7.x. |
|
rely on this config too , in version 6.x |
|
Closing as this has now been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Based on the Delete By Query API documentation, the
slicesfield may be set toauto.The
DeleteByQueryRequeststruct only allows*intas input, as does theDeleteByQuerymethod, so there does not currently appear to be a way to set that value using this library.The text was updated successfully, but these errors were encountered: