Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI; theme refactor #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade EUI; theme refactor #54

wants to merge 2 commits into from

Conversation

thompsongl
Copy link
Contributor

  • Updates Gatsby to v3
    • v4 is latest, but it was not a smooth upgrade
    • require-based theme switching no longer works. See later note.
  • Updates various build deps
    • Necessary to pass the type check
    • Now works on node.js v16 🎉
  • Updates EUI to latest version
  • Uses EuiProvider
  • Refactors theme switching
    • Gatsby forces a single CSS blob with no way to unload the not-in-use-theme
    • Both themes are bundled and switching is done with a global class
    • Not super happy with it, but unsure of other approaches right now
    • Not having to do a page reload is kind of nice, though 🤷‍♂️

@thompsongl thompsongl marked this pull request as ready for review December 22, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thompsongl