Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssl configuration to fleet server http. #98

Merged
merged 4 commits into from
Feb 22, 2021

Conversation

blakerouse
Copy link
Contributor

What does this PR do?

Adds the ability to configure the TLS of the HTTP endpoint exposed by Fleet Server.

Why is it important?

So Elastic Agent can configure and expose the Fleet Server over HTTPS.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@blakerouse blakerouse added the Team:Elastic-Agent Label for the Agent team label Feb 19, 2021
@blakerouse blakerouse self-assigned this Feb 19, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 19, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #98 updated

  • Start Time: 2021-02-19T15:49:57.019+0000

  • Duration: 4 min 8 sec

  • Commit: 9682917

Test stats 🧪

Test Results
Failed 0
Passed 50
Skipped 0
Total 50

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Member

@aleksmaus aleksmaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blakerouse blakerouse merged commit 9d451b7 into elastic:master Feb 22, 2021
blakerouse added a commit to blakerouse/fleet-server that referenced this pull request Feb 22, 2021
* Add ssl configuration to fleet server http configuration.

* Add log message when tls disabled.

* Fix import.

* Fix integration test.

(cherry picked from commit 9d451b7)
@blakerouse blakerouse deleted the http-ssl-config branch February 22, 2021 14:11
blakerouse added a commit that referenced this pull request Feb 22, 2021
* Add ssl configuration to fleet server http configuration.

* Add log message when tls disabled.

* Fix import.

* Fix integration test.

(cherry picked from commit 9d451b7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants