Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve expired actions cleanup, use _delete_by_query instead #906

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Improve expired actions cleanup, use _delete_by_query instead #906

merged 2 commits into from
Nov 23, 2021

Conversation

aleksmaus
Copy link
Contributor

What is the problem this PR solves?

Improve expired actions cleanup, use _delete_by_query instead.
The original implementation was selecting action ids and deleted them by document id, although batched, it was suboptimal.

How does this PR solve the problem?

Replaces current cleanup implementation with _delete_by_query

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@aleksmaus aleksmaus added enhancement New feature or request cleanup 8.0-candidate backport-v8.0.0 Automated backport with mergify labels Nov 22, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 22, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-23T11:19:38.072+0000

  • Duration: 9 min 44 sec

  • Commit: a0b1e60

Test stats 🧪

Test Results
Failed 0
Passed 229
Skipped 0
Total 229

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@aleksmaus aleksmaus merged commit fae23a3 into elastic:master Nov 23, 2021
@aleksmaus aleksmaus deleted the improve/actions_cleanup branch November 23, 2021 11:36
mergify bot pushed a commit that referenced this pull request Nov 23, 2021
@aleksmaus
Improve expired actions cleanup, use _delete_by_query instead (#906)
b56a258 
* Improve expired actions cleanup, use _delete_by_query instead

(cherry picked from commit fae23a3)
@mergify mergify bot mentioned this pull request Nov 23, 2021
Merged
@aleksmaus aleksmaus restored the improve/actions_cleanup branch November 23, 2021 11:36
mergify bot added a commit that referenced this pull request Nov 23, 2021
@mergify @aleksmaus
Improve expired actions cleanup, use _delete_by_query instead (#906) (#…
a5cff0f 
…910)

* Improve expired actions cleanup, use _delete_by_query instead

(cherry picked from commit fae23a3)

Co-authored-by: Aleksandr Maus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scunningham scunningham scunningham approved these changes

@lykkin lykkin Awaiting requested review from lykkin

Assignees
No one assigned
Labels
8.0-candidate backport-v8.0.0 Automated backport with mergify cleanup enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleksmaus @elasticmachine @scunningham