Fix self monitor to report starting waiting on fleet-server input #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o be added to policy.
blakerouse
added
the
Team:Elastic-Agent-Control-Plane
|
This pull request does not have a backport label. Could you fix it @blakerouse? 🙏
NOTE: |
mergify
bot
added
the
backport-skip
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
3 tasks
aleksmaus
approved these changes
Oct 11, 2021
mergify
bot
removed
the
backport-skip
blakerouse
added
backport-skip
mergify bot
added a commit
that referenced
this pull request
Oct 11, 2021
…o be added to policy. (#768) (#774) (cherry picked from commit 334cd2d) Co-authored-by: Blake Rouse <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Oct 11, 2021
…o be added to policy. (#768) (#773) (cherry picked from commit 334cd2d) Co-authored-by: Blake Rouse <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
This solves the issue where Kibana could create the policy that fleet-server is waiting to exist, but when Kibana creates it, it doesn't add the
fleet-serverinput to it. Before fleet-server would report this as an error and would cause the Elastic Agent to keep restarting thefleet-serverconstantly.How does this PR solve the problem?
This solves the issue by changing the logic to report the missing input as starting. This will allow the Elastic Agent to keep the
fleet-serverprocess running (removing the constant restart loop). Elastic Agent will also print the nice message that fleet-server provides back to the user.Once the
fleet-serverinput is added to the policy,fleet-serverwill notice that it now exists and will continue to normal operation.Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues