Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set User-Agent in HTTP requests #654

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Set User-Agent in HTTP requests #654

merged 2 commits into from
Sep 1, 2021

Conversation

aleksmaus
Copy link
Member

What does this PR do?

  • Set User-Agent in HTTP requests that looks like the following:
User-Agent: Elastic-Fleet-Server/8.0.0 (darwin; amd64; b1fef53; 2021-08-23 18:50:14 +0000 UTC)
  • Update elasticsearch client on the 7.x branch commit that implemented the addition of the User-Agent elastic/go-elasticsearch@845c8ef
  • Add built time for consistency with the libbeat user agent

Why is it important?

Not sure how important this is, but it addresses #636
Leaving up to the Fleet/Agent team to decide if this is needed or not.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas

Related issues

Screenshots

Wireshark capture
Screen Shot 2021-08-23 at 2 51 45 PM

@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 23, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-31T12:20:37.376+0000

  • Duration: 5 min 48 sec

  • Commit: a4f094b

Test stats 🧪

Test Results
Failed 0
Passed 215
Skipped 0
Total 215

Trends 🧪

Image of Build Times

Image of Tests

scunningham
scunningham approved these changes Aug 30, 2021
View reviewed changes
Copy link

@scunningham scunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aleksmaus aleksmaus added enhancement New feature or request v7.16.0 Team:Elastic-Agent Label for the Agent team labels Aug 30, 2021
@aleksmaus
Copy link
Member Author

hmm: CI "Error: Action failed with error: Error querying project card for Pull request number 654: Bad credentials"

@aleksmaus aleksmaus merged commit 96f184e into elastic:master Sep 1, 2021
mergify bot pushed a commit that referenced this pull request Sep 1, 2021
@aleksmaus
Set User-Agent in HTTP requests (#654)
a9855d6 
* Set User-Agent in HTTP requests

* Adjust integration test

(cherry picked from commit 96f184e)
@mergify mergify bot mentioned this pull request Sep 1, 2021
Merged
mergify bot added a commit that referenced this pull request Sep 1, 2021
@mergify @aleksmaus
Set User-Agent in HTTP requests (#654) (#690)
c4749f2 
* Set User-Agent in HTTP requests

* Adjust integration test

(cherry picked from commit 96f184e)

Co-authored-by: Aleksandr Maus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scunningham scunningham scunningham approved these changes

@michalpristas michalpristas Awaiting requested review from michalpristas

@blakerouse blakerouse Awaiting requested review from blakerouse

Assignees
No one assigned
Labels
enhancement New feature or request Team:Elastic-Agent Label for the Agent team v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set User-Agent in HTTP requests
3 participants
@aleksmaus @elasticmachine @scunningham