Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[updatecli] update elastic stack version for testing 9.0.0-070836bc-SNAPSHOT #3962

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 30, 2024

Bump elastic-stack to latest snapshot version

Update snapshot.yml

1 file(s) updated with "$1=9.0.0-070836bc-SNAPSHOT": * dev-tools/integration/.env

GitHub Action workflow link
Updatecli logo

Created automatically by Updatecli

Options:

Most of Updatecli configuration is done via its manifest(s).

  • If you close this pull request, Updatecli will automatically reopen it, the next time it runs.
  • If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.

Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!

Made with ❤️️ by updatecli
@github-actions github-actions bot added automation dependency backport-skip Skip notification from the automated backport with mergify labels Sep 30, 2024
@jlind23
Copy link
Contributor

jlind23 commented Sep 30, 2024

buildkite test it

@jlind23 jlind23 enabled auto-merge (squash) September 30, 2024 17:39
@jlind23
Copy link
Contributor

jlind23 commented Oct 1, 2024

This looks like a real bug/problem as TestBulkCreate/Invalid_utf-8 is the one that blocks this PR.

@ycombinator
Copy link
Contributor

This looks like a real bug/problem as TestBulkCreate/Invalid_utf-8 is the one that blocks this PR.

The test fails like so:

=== RUN   TestBulkCreate/Invalid_utf-8
--
  | bulk_integration_test.go:103: expected error: elastic fail 400: parse_exception, got: elastic fail 500: json_parse_exception: Invalid UTF-8 start byte 0xfe
  | at [Source: (byte[])"{"create":{"_index":"����"}}"; line: 1, column: 23]

Looks like the test expects a json_parse_exception so that bit is fine. But the test is also expecting a 400 response but ES is returning a 500 response. I wonder if this is something that changed in 9.0. @michel-laterman would you mind investigating?

Made with ❤️️ by updatecli
@github-actions github-actions bot changed the title [updatecli] update elastic stack version for testing 9.0.0-9f6b098e-SNAPSHOT [updatecli] update elastic stack version for testing 9.0.0-070836bc-SNAPSHOT Oct 1, 2024
@michel-laterman michel-laterman requested a review from a team as a code owner October 1, 2024 16:53
@michel-laterman
Copy link
Contributor

Yes, the change is an upstream ES change where the original behavior was to return a 500/json_parse_exception when invalid utf-8 was detected (in es), which changed to a 400/parse_exception and has now changed back

Copy link

@jlind23 jlind23 merged commit 5448f49 into main Oct 1, 2024
8 checks passed
@jlind23 jlind23 deleted the updatecli_main_bump-elastic-stack-snapshot-main branch October 1, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation backport-skip Skip notification from the automated backport with mergify dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants