-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alter checkin API to remove attributes set by audit/unenroll API #3827
Merged
michel-laterman
merged 16 commits into
elastic:main
from
michel-laterman:audit-unenroll-checkin
Aug 26, 2024
Merged
Alter checkin API to remove attributes set by audit/unenroll API #3827
michel-laterman
merged 16 commits into
elastic:main
from
michel-laterman:audit-unenroll-checkin
Aug 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-laterman
added
enhancement
New feature or request
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
labels
Aug 21, 2024
buildkite test this |
michel-laterman
commented
Aug 22, 2024
michel-laterman
requested review from
andrzej-stencel,
pchila,
blakerouse and
intxgo
August 22, 2024 18:35
michel-laterman
force-pushed
the
audit-unenroll-checkin
branch
from
August 22, 2024 18:51
f015e9c
to
59e2f21
Compare
blakerouse
reviewed
Aug 22, 2024
Quality Gate passedIssues Measures |
blakerouse
approved these changes
Aug 23, 2024
buildkite run perf-tests |
1 similar comment
buildkite run perf-tests |
I realized that the perf-tests here don't actually use the changed endpoint; i'll work on altering them to do so in other prs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
Follow up to #3818, alters the checkin API to remove attributes that the audit/unenroll endpoint sets
How does this PR solve the problem?
Alter the checkin wrapper's flush method to include bulk update calls to remove the attributes for agents that have a non-empty
audit_unenrolled_reason
.How to test this PR locally
audit/unenroll
API to annotate the agent document.checkin
api to signal the agent is healthyAgent document in Elasticsearch should no longer have the
audit_unenrolled_reason
or associated attributesDesign Checklist
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files./changelog/fragments
using the changelog toolRelated issues