Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go version 1.16.4 #341

Merged
merged 4 commits into from
May 26, 2021

Conversation

michel-laterman
Copy link
Contributor

@michel-laterman michel-laterman commented May 11, 2021

What does this PR do?

Update Go to version 1.16.4.

Related issues

@michel-laterman michel-laterman added enhancement New feature or request Team:Elastic-Agent Label for the Agent team v7.14.0 labels May 11, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented May 11, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #341 updated

  • Start Time: 2021-05-26T16:05:59.811+0000

  • Duration: 4 min 27 sec

  • Commit: c475b9a

Test stats 🧪

Test Results
Failed 0
Passed 174
Skipped 0
Total 174

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@michel-laterman
Copy link
Contributor Author

@mdelapenya, the ci build is still using go 1.15.8, and not the go 1.16.4 version from the .go-version file; do you know why?

@mdelapenya
Copy link
Contributor

@mdelapenya, the ci build is still using go 1.15.8, and not the go 1.16.4 version from the .go-version file; do you know why?

Currently looking into it

@mdelapenya
Copy link
Contributor

@mdelapenya, the ci build is still using go 1.15.8, and not the go 1.16.4 version from the .go-version file; do you know why?

The run_with_go_ver script is not used in any Make goal apart from the release-manager-release one. I think that's the root cause.

On the other hand, I can see that gimme is used to install Go. In Beats, the team is using @andrewkroh's gvm tool. Is that on purpose?

@mdelapenya
Copy link
Contributor

mdelapenya commented May 13, 2021

I created #345, and will send a PR to fix it

UPDATE: The PR is there! #346

@michel-laterman
Copy link
Contributor Author

jenkins run tests

@michel-laterman
Copy link
Contributor Author

jenkins run tests

1 similar comment
@michel-laterman
Copy link
Contributor Author

jenkins run tests

@blakerouse
Copy link
Contributor

@michel-laterman I think this is ready to land, if you want to click merge.

@michel-laterman
Copy link
Contributor Author

@blakerouse, Should we add any notes about the min macos version needed with the new crossbuild image (10.14)?

@blakerouse
Copy link
Contributor

@michel-laterman Adding a note would be helpful.

@michel-laterman michel-laterman merged commit 75d8242 into elastic:master May 26, 2021
@michel-laterman michel-laterman deleted the go-1.16.4 branch May 26, 2021 16:55
mergify bot pushed a commit that referenced this pull request May 26, 2021
* Update to Go version 1.16.4

* Add MacOSX version note to readme

(cherry picked from commit 75d8242)

# Conflicts:
#	README.md
mergify bot added a commit that referenced this pull request May 26, 2021
* Update to Go version 1.16.4

* Add MacOSX version note to readme

(cherry picked from commit 75d8242)

# Conflicts:
#	README.md

Co-authored-by: Michel Laterman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Elastic-Agent Label for the Agent team v7.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants