-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix file delivery order #3283
Merged
Merged
Fix file delivery order #3283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzl
added
bug
Something isn't working
backport-v8.11.0
Automated backport with mergify
backport-v8.12.0
Automated backport with mergify
backport-v8.13.0
Automated backport with mergify
backport-v8.10.0
Automated backport with mergify
labels
Feb 14, 2024
juliaElastic
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
buildkite test this |
michel-laterman
approved these changes
Feb 20, 2024
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
(cherry picked from commit 485fad9)
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
(cherry picked from commit 485fad9)
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
(cherry picked from commit 485fad9)
This was referenced Feb 22, 2024
juliaElastic
pushed a commit
that referenced
this pull request
Feb 23, 2024
(cherry picked from commit 485fad9) Co-authored-by: Dan Panzarella <[email protected]>
juliaElastic
pushed a commit
that referenced
this pull request
Feb 23, 2024
(cherry picked from commit 485fad9) Co-authored-by: Dan Panzarella <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v8.11.0
Automated backport with mergify
backport-v8.12.0
Automated backport with mergify
backport-v8.13.0
Automated backport with mergify
bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
Chunked file delivery would occasionally be delivered out-of-order for certain file sizes
How does this PR solve the problem?
Chunk identifiers (not binary contents, just a few metadata fields) are just manually sorted in code. The positional order is not stored in the chunk documents, only contained in a doc's
_id
field, which is not a sortable result. Given a upper limit of file size (100mb) and fixed chunk size (4mb), the upper bound for number of documents here is 25. Software sort is reasonable enoughHow to test this PR locally
Update
securitySolution.maxUploadResponseActionFileBytes
in kibana.yml to be104857600
spin up an endpoint, use the responder console to upload a ~90mb file. The bug reproducing-error is a file hash mismatch. With this fix, hashes will match and the action will be marked success
Design Checklist
Checklist
./changelog/fragments
using the changelog toolRelated issues