Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openapi docs for File Upload routes #2299
Openapi docs for File Upload routes #2299
Changes from 4 commits
62cbde4
628b833
3758808
cb877a4
796cdd4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the
contents
array just an array of objects? Is there any definition for it anywhere?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I wasn't sure how much to explain.
The required fields are explicitly mapped. Everything else is unmapped, but
dynamic: true
is set on the mapping. So integrations can just index whatever they want, in whatever format.Considering zip/archive is a common use case, I wanted to suggest a convention (have
file
describe the zip, andcontents: [ {}, {}, {} ...]
describe the files inside). But it is not required, enforced, anything. Just a suggested convention.The mappings are not shared between integrations, so any client can do what they want. That's why this isn't a very prescriptive definition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add other responses?
I'm also assuming there's no 428 response anymore