This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
Fix spelling and formatting issues #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypid-geberit
force-pushed
the
fix-spelling
branch
2 times, most recently
from
e5679e5 to
8dc9714
Compare
I the run tests for all watches which I have modified to verify that they still pass.
ypid-geberit
force-pushed
the
fix-spelling
branch
from
8dc9714 to
a18a435
Compare
EthanStrider
suggested changes
Feb 9, 2021
| * Any other code that is a part of the instruction set. Scripts should be documented and dependencies available in a standard format e.g.for Python a requirements.txt and pip would be appropriate. Always detail tested language versions for scripts e.g.Python 3.5.x | ||
|
|
||
| * **Data** <br> | ||
| You can either provide the data file with the example (for small sample datasets), or provide instructions / link to download the raw data (or Elasticsearch index snapshot) from another source (such as Amazon S3). 10mb is a reasonable threshold before moving to an external download- but this shouldn't be considered a hardline. | ||
|
|
||
| You can either provide the data file with the example (for small sample datasets), or provide instructions / link to download the raw data (or Elasticsearch index snapshot) from another source (such as Amazon S3). 10 MiB is a reasonable threshold before moving to an external download- but this shouldn't be considered a hardline. |
There was a problem hiding this comment.
Not really. MB is ambiguous. MiB is better defined which is why you will find good technical documentation often uses it
https://en.wikipedia.org/wiki/Byte#Multiple-byte_units.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I the run tests for all watches which I have modified to verify that they still pass.